search

pfnet / pfrl

PFRL: a PyTorch-based deep reinforcement learning library
MIT License
1.18k stars 158 forks source link

Set stats type #83

Closed marioyc closed 3 years ago

marioyc commented 3 years ago

Call _set_mode in Monitor to set the stats type as done here

tkelestemur commented 3 years ago

Since the PFRL's Monitor call the __init__ function of the Gym's Monitor, it already sets the mode right? Why do we need to set it again?

Edit: PPO Atari example sets the mode while wrapping the environments so that might mean that functional already works.

marioyc commented 3 years ago

that will set the type for the initial self.stats_recorder but we overwrite with PFRL's _StatsRecorder which mode doesn't affect

tkelestemur commented 3 years ago

Oh okay, that make sense. I went ahead and tried your change and it successfully labels eval environments as e in .json files.