search

pfnet / pysen

Python linting made easy. Also a casual yet honorific way to address individuals who have entered an organization prior to you.
MIT License
487 stars 20 forks source link

Update lint extras for py39 #22

Closed Hakuyume closed 1 year ago

Hakuyume commented 2 years ago

Since PFN uses py39 widely, pysen[lint] should work with py39. Current lint extras tries to install older black and it does not work with py39.

(optional) Can we drop py36 and py37 support?

sergeant-wizard commented 2 years ago

The error in question can be reproduced by running the following at the root of pysen repo:

docker run --workdir /ws -v $(pwd):/ws python:3.9-slim-buster bash -c "pip install pysen[lint] && pysen run lint"

The issue is reported here as well: https://github.com/python/typed_ast/issues/169

bonprosoft commented 2 years ago

Thank you! +1 to upgrade black to work with py39.

sergeant-wizard commented 1 year ago

The error in question can be reproduced by running the following at the root of pysen repo:

docker run --workdir /ws -v $(pwd):/ws python:3.9-slim-buster bash -c "pip install pysen[lint] && pysen run lint"

The issue is reported here as well: python/typed_ast#169

I confirmed that the error from black in question is resolved in 0.10.3