pfpayments / prestashop-1.6

PostFinance Checkout integration for PrestaShop 1.6
https://www.postfinance-checkout.ch
Apache License 2.0
0 stars 0 forks source link

Payment selection displays two buttons, and both of them are not working #5

Closed lmeyer1 closed 1 year ago

lmeyer1 commented 2 years ago

Describe the bug When placing an order on Prestashop with Postfinance Checkout, the display of the page is not coherent, there are two buttons labelled I confirm my order, that do not have the same effect. Additionally neither of both button confirms the order.

To Reproduce On a default installation (see below for instructions for set up) Steps to reproduce the behavior:

  1. Open the shop with Chrome

  2. Add a product to the cart

  3. Place the order, on step 5. Paiement, choose Carte Postfinance

  4. Notice the strange display with the two buttons

  5. Hit F12 to open Chrome Dev Console

  6. Click on the first button

  7. Note the error in the Dev console

    checkout.js:90 Uncaught TypeError: Cannot read properties of undefined (reading 'processing')
    at HTMLButtonElement.handler_submit (checkout.js:90:22)
    at HTMLButtonElement.dispatch (jquery-1.11.0.min.js:3:8066)
    at HTMLButtonElement.r.handle (jquery-1.11.0.min.js:3:4767)
  8. Click on the second button

  9. An empty page displays, with an error in Dev console 2022-01-28_152409 2022-01-28_152420

Expected behavior We should be able to place an order.

Screenshots There are two buttons I confirm my order 2022-01-28_152117

Software versions:

Additional Info

About the Javascript error: the offending lines in file views/js/frontend/checkout.js are:

    handler_submit : function (event) {
        if(!self.processing) {
            var self = event.data.self;
            self.disable_pay_button();

Obviously var self = event.data.self; should precede if(!self.processing) {

Set up a clean installation If you do not have a test environment to reproduce this issue, this is how to set up a default installation:

theodorspringwallee commented 1 year ago

Dear lmeyer1

Sorry for the late response.

Is this issue still relevant for you?

lmeyer1 commented 1 year ago

Just a quick look at the code and the is still no translation in french. See https://github.com/pfpayments/prestashop-1.6/issues/4

Are you kidding? This product is for Switzerland. Do you ignore that Switzerland has four national languages and is not only german speaking?

lmeyer1 commented 1 year ago

@theodorspringwallee You closed this issue as Fixed, what is not true. It would have been more honest to close it as Won't fix, wouldn't it ?