pfps / yoga-laptop

Systems and information to make Lenovo Yoga laptops work better
GNU General Public License v3.0
156 stars 30 forks source link

fixes #42 added Yoga 3 14 to the list of hardware which doesn't have … #43

Closed swinstanley closed 9 years ago

swinstanley commented 9 years ago

…any hardware wifi kill switch

Yoga 3 14 has kbd layout the same as a Yoga 2 and ubuntu 14.04 the wifi is similarly hardware disabled. The Makefile update is to account for the change in the hwdb.d location between Ubuntu and Fedora (which I guess is was the original target of the fix).

I have tested it on this Laptop only, I would guess that more models may also apply but I added a specific model match because no other test platforms existed where I was sat, there could be other issues, the wifi is now working correctly however.

pfps commented 9 years ago

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256

I see that you forked the code.

If you push back to my repo I'll integrate your changes.

What really should do, however, is get this change applied to the current kernel module. You need to download the current module, make the change, prepare a patch, and mail the patch to [somewhere that I have forgotten].

If you are planing on doing this, I'll try to remember the missing steps.

peter

On 06/17/2015 02:05 AM, Sam Winstanley wrote:

…any hardware wifi kill switch

Yoga 3 14 has kbd layout the same as a Yoga 2 and ubuntu 14.04 the wifi is similarly hardware disabled. The Makefile update is to account for the change in the hwdb.d location between Ubuntu and Fedora (which I guess is was the original target of the fix).

I have tested it on this Laptop only, I would guess that more models may also apply but I added a specific model match because no other test platforms existed where I was sat, there could be other issues, the wifi is now working correctly however.



You can view, comment on, or merge this pull request online at:

https://github.com/pfps/yoga-laptop/pull/43

Commit Summary

  • fixes #42 added Yoga 3 14 to the list of hardware which doesn't have any hardware wifi kill switch

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/pfps/yoga-laptop/pull/43.

-----BEGIN PGP SIGNATURE----- Version: GnuPG v2

iQEcBAEBCAAGBQJVgZIPAAoJECjN6+QThfjz4m4IAKxcGiCSqg6OKTfKp8hh/w7P xGMPRQcFowKvSvlFzPgkGiBOok8B/Oq1qVLhTRtIWL+NrtdaT6tJ5uRb+3+0R5bJ NaCtByiUKKg3Ps7VOZzcdp8aiy0PuJaFFMoao3fVSPcIm5r3F/pojDQei/CMMrCd EMYIzh0QH1zSjVynz6ECCuNM34hsygXa61twsBRCbgnnnhRetXZDJ1/pxmM4WMDE fl5PX5SwS3MUvTGN2SF5K55sSFa9LLUn8ngRUAvpa00yPrNJPjLLhEDU6uKx18Gd S2AxksBLCnAo24KQXlnjtnAZa+DbEBQaKro6gMybcS0P7EG0jX9uQ/sW/1uOwbI= =9AIW -----END PGP SIGNATURE-----

guilhem commented 9 years ago

This patch have been proposed for merging http://lkml.iu.edu/hypermail/linux/kernel/1506.1/04574.html who fix ideapad + yoga 3 14

pfps commented 9 years ago

Looks OK - merged.

However, you should also try to get this merged into the Linux driver.