search

pfps / yoga-laptop

Systems and information to make Lenovo Yoga laptops work better
GNU General Public License v3.0
156 stars 30 forks source link

Replace system() calls by direct libnotify library calls. #47

Closed chhtz closed 8 years ago

chhtz commented 8 years ago

This adds a dependency on libnotify-dev. If you don't like this, please remove the fork() call, or replace the system() call by a corresponding execl() call -- otherwise, you'll spawn a new thread for every new notification which is never killed. Also, if the icons I chose don't work generically (they work on ubuntu+xfce, I did not test anything else), feel free to change them (though the previous values will have worked on even fewer systems g)

chhtz commented 8 years ago

@pfps Any objections/questions/remarks about this pull request?

pfps commented 8 years ago

Looks OK, I pulled it.

peter

On 11/29/2015 06:09 AM, Christoph Hertzberg wrote:

@pfps https://github.com/pfps Any objections/questions/remarks about this pull request?

— Reply to this email directly or view it on GitHub https://github.com/pfps/yoga-laptop/pull/47#issuecomment-160418289.

tomheinisch commented 8 years ago

In my case, sensors and touchpad don't work after a reboot. This was why I originally opened #51 However, all seems to work after suspending and waking up my Yoga... Any ideas?

pfps commented 8 years ago

This is probably due to some not-quite-correct initialization of your hardware. I don't know what it responsible for the initialization (if anything). You may want to open a new thing devoted to this topic.