pfps / yoga-laptop

Systems and information to make Lenovo Yoga laptops work better
GNU General Public License v3.0
156 stars 30 forks source link

Ubuntu 15.10 - notify.h not found #51

Closed tomheinisch closed 8 years ago

tomheinisch commented 8 years ago
make
cd sensors && make all
make[1]: Entering directory '/home/tom/yoga-laptop/sensors'
cc orientation.c  -o orientation
^[[Aorientation.c:32:30: fatal error: libnotify/notify.h: No such file or directory 
compilation terminated.
Makefile:16: recipe for target 'orientation' failed
make[1]: *** [orientation] Error 1

Any ideas?

Many thanks, Tom

chhtz commented 8 years ago

You need to install libnotify-dev

tomheinisch commented 8 years ago

Thanks for that - it seems to have brought me one step further, but now another error message comes up:

make programs
cd sensors && make all
make[1]: Entering directory '/home/tom/yoga-laptop/sensors'
cc orientation.c  -o orientation
In file included from orientation.c:32:0:
/usr/include/libnotify/notify.h:25:18: fatal error: glib.h: No such file or directory
compilation terminated.
Makefile:16: recipe for target 'orientation' failed
make[1]: *** [orientation] Error 1
make[1]: Leaving directory '/home/tom/yoga-laptop/sensors'
Makefile:9: recipe for target 'programs' failed
make: *** [programs] Error 2

After that, I tried to find out whether libglib-2.0 was properly installed - it seems it was, under /usr/include/glib-2.0.

/usr/include/libnotify/notify.h tries to include it using

include

That would refer to /usr/include/glib.h - does that cause the problem?

Thanks again.

chhtz commented 8 years ago

What does pkg-config --cflags --libs libnotify return?

tomheinisch commented 8 years ago
-pthread -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/x86_64 linux-gnu/glib-2.0/include -lnotify -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 
chhtz commented 8 years ago

It seems, in my pull-request #47, I accidentally added line 17 instead of replacing line 16. @pfps Can you remove that line from the Makefile (I don't want to open a PR for that single line)?

pfps commented 8 years ago

What is the exact change required?

chhtz commented 8 years ago

Remove this line: https://github.com/pfps/yoga-laptop/blob/master/sensors/Makefile#L16

pfps commented 8 years ago

Should be done

tomheinisch commented 8 years ago

This is now solved.