search

pfps / yoga-laptop

Systems and information to make Lenovo Yoga laptops work better
GNU General Public License v3.0
156 stars 30 forks source link

add digitizer rotation support to orientation #53

Closed tynsh closed 7 years ago

tynsh commented 7 years ago

I've added the option to specify an other xinput device to get rotation of digitizer pen inputs working. The reason is, that at least the thinkpad yoga series has the option of a digitizer.

If a device does not have the default digitizer xinput device called "Wacom ISDv4 EC Pen stylus" ,orientation, or more precisely xinput, currently prints: "unable to find device Wacom ISDv4 EC Pen stylus". I'm not sure how to handle this correctly, because checking for the existence of the input device is hard to do cleanly and on the other hand adding a commandline flag to enable digitizer rotation adds unnecessary complexity for the user.

Do you have an idea what would be best to do?

tynsh commented 7 years ago

forgot to add: please do not merge this as of now, since I've not added documentation for this yet.

benklop commented 7 years ago

hey @tynsh, I wonder if you find #56 to be a good alternative? It isn't specific to digitizers exactly, but just allows specifying --touchscreen multiple times. My tablet has 2 digitizer devices (eraser and stylus) and a touch device.

tynsh commented 7 years ago

you are right, I'll comment on #56 later. Your approach is better than this one so I'm closing this ;-)