search

pfultz2 / cget

C++ package retrieval
http://cget.readthedocs.io
Other
453 stars 27 forks source link

Add link_directories to cget.cmake #39

Closed usernameiwantedwasalreadytaken closed 7 years ago

usernameiwantedwasalreadytaken commented 7 years ago

The generated cget.cmake file does include a include_directories(SYSTEM ${CMAKE_PREFIX_PATH}/include) statement.

However, it would be nice if it included a similar link_directories(${CMAKE_PREFIX_PATH}/lib) statement.

Right now, I have to add this in my own CMakeLists.txt, so this is not a problem, just a suggestion.

pfultz2 commented 7 years ago

I have thought about it, but packages, generally, use find_library to link a library, which is more robust. However, a lot of header-only libraries just assume the headers are available, so the include_directories is necessary.

usernameiwantedwasalreadytaken commented 7 years ago

Ok. That makes sense.