pg-redis-fdw / redis_fdw

A PostgreSQL foreign data wrapper for Redis
493 stars 68 forks source link

Redis Clustering support #32

Open jeffreydwalter opened 2 years ago

jeffreydwalter commented 2 years ago

Hello, I had a need to use fdw with a redis cluster. I hacked up this fdw that has basic feature parity with redis_fdw. Is this something you guys would like to take over and maintain? https://github.com/jeffreydwalter/redis_cluster_fdw

Cheers, Jeff

luss commented 2 years ago

perhaps... What useful stuff did you add to the base redis_fdw?

On Tue, Oct 5, 2021 at 12:15 PM Jeffrey Walter @.***> wrote:

Hello, I had a need to use fdw with a redis cluster. I hacked up this fdw that has basic feature parity with redis_fdw. Is this something you guys would like to take over and maintain? https://github.com/jeffreydwalter/redis_cluster_fdw

Cheers, Jeff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pg-redis-fdw/redis_fdw/issues/32, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMWOHSIJK2IRV6LPOKELJDUFMQCRANCNFSM5FMCF24Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jeffreydwalter commented 2 years ago

Hi Denis,

I added the ability to connect to a Redis cluster.

On Tue, Oct 5, 2021, 12:06 PM Denis Lussier @.***> wrote:

perhaps... What useful stuff did you add to the base redis_fdw?

On Tue, Oct 5, 2021 at 12:15 PM Jeffrey Walter @.***> wrote:

Hello, I had a need to use fdw with a redis cluster. I hacked up this fdw that has basic feature parity with redis_fdw. Is this something you guys would like to take over and maintain? https://github.com/jeffreydwalter/redis_cluster_fdw

Cheers, Jeff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pg-redis-fdw/redis_fdw/issues/32, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAMWOHSIJK2IRV6LPOKELJDUFMQCRANCNFSM5FMCF24Q

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pg-redis-fdw/redis_fdw/issues/32#issuecomment-934597102, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEKOB6YD4CGO4NBEYWAG2DUFMWAXANCNFSM5FMCF24Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

luss commented 2 years ago

Why didn't u fork redis_fdw so it would be easier for this parent project you used a basis to consider taking pull requests from you (and you becoming a commiter in that project). Andrew and Dave are (mostly) reasonable guys. :-)

On Tue, Oct 5, 2021 at 2:20 PM Jeffrey Walter @.***> wrote:

Hi Denis,

I added the ability to connect to a Redis cluster.

On Tue, Oct 5, 2021, 12:06 PM Denis Lussier @.***> wrote:

perhaps... What useful stuff did you add to the base redis_fdw?

On Tue, Oct 5, 2021 at 12:15 PM Jeffrey Walter @.***> wrote:

Hello, I had a need to use fdw with a redis cluster. I hacked up this fdw that has basic feature parity with redis_fdw. Is this something you guys would like to take over and maintain? https://github.com/jeffreydwalter/redis_cluster_fdw

Cheers, Jeff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pg-redis-fdw/redis_fdw/issues/32, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAMWOHSIJK2IRV6LPOKELJDUFMQCRANCNFSM5FMCF24Q

. Triage notifications on the go with GitHub Mobile for iOS <

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android <

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/pg-redis-fdw/redis_fdw/issues/32#issuecomment-934597102 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAEKOB6YD4CGO4NBEYWAG2DUFMWAXANCNFSM5FMCF24Q

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pg-redis-fdw/redis_fdw/issues/32#issuecomment-934654488, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMWOHTI5YKRQRA4SUGS6LDUFM6YVANCNFSM5FMCF24Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jeffreydwalter commented 2 years ago

I didn't fork it because it doesn't work with non-clustered redis, so I didn't see the point. I considered making it work for both, but wanted to get this working first.

On Tue, Oct 5, 2021, 1:50 PM Denis Lussier @.***> wrote:

Why didn't u fork redis_fdw so it would be easier for this parent project you used a basis to consider taking pull requests from you (and you becoming a commiter in that project). Andrew and Dave are (mostly) reasonable guys. :-)

On Tue, Oct 5, 2021 at 2:20 PM Jeffrey Walter @.***> wrote:

Hi Denis,

I added the ability to connect to a Redis cluster.

On Tue, Oct 5, 2021, 12:06 PM Denis Lussier @.***> wrote:

perhaps... What useful stuff did you add to the base redis_fdw?

On Tue, Oct 5, 2021 at 12:15 PM Jeffrey Walter @.***> wrote:

Hello, I had a need to use fdw with a redis cluster. I hacked up this fdw that has basic feature parity with redis_fdw. Is this something you guys would like to take over and maintain? https://github.com/jeffreydwalter/redis_cluster_fdw

Cheers, Jeff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pg-redis-fdw/redis_fdw/issues/32, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAMWOHSIJK2IRV6LPOKELJDUFMQCRANCNFSM5FMCF24Q

. Triage notifications on the go with GitHub Mobile for iOS <

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android <

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/pg-redis-fdw/redis_fdw/issues/32#issuecomment-934597102

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAEKOB6YD4CGO4NBEYWAG2DUFMWAXANCNFSM5FMCF24Q

. Triage notifications on the go with GitHub Mobile for iOS <

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android <

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/pg-redis-fdw/redis_fdw/issues/32#issuecomment-934654488 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAMWOHTI5YKRQRA4SUGS6LDUFM6YVANCNFSM5FMCF24Q

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pg-redis-fdw/redis_fdw/issues/32#issuecomment-934677884, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEKOB72AUDI3G6VKP5R7JTUFNCGRANCNFSM5FMCF24Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jeffreydwalter commented 2 years ago

Feel free to take a look at my repo and consider whether there's interest in taking it over. If you want the code, it might make sense to setup an empty repo for redis_cluster_fdw, which I can fork and make a PR against.