fixes: develop docker will never create new build

pgRouting / docker-pgrouting

Docker for pgRouting

https://hub.docker.com/repository/docker/pgrouting/pgrouting

GNU General Public License v2.0

64 stars 34 forks source link

fixes: develop docker will never create new build #24

Closed smellman closed 4 years ago

smellman commented 4 years ago

Changes proposed in this pull request:

fixes: Dockerfile for develop branch will never create new build because nothing changed
- update.sh check current branch's hash and fetch only this hash

@pgRouting/admins

smellman commented 4 years ago

Note: I added : before hash in git fetch to support old git command.

git fetch --depth 1 origin :d93c618ae9c2c57885c8a52287ae226ee7b9a4a4

aruneko commented 4 years ago

I have a question for @cvvergara .

Which branch is for developing? It seems that master branch is ahead of develop branch.

smellman commented 4 years ago

It is easy to supports both develop and master branch.

dkastl commented 4 years ago

@aruneko , you're right. We should probably follow the same convention as in other repositories to first point PR's in develop branch and merge from there into master. But we also lack somehow releases and versioning for this repository.

smellman commented 4 years ago

@aruneko @dkastl I added master version. It's easy task.

cayetanobv commented 4 years ago

@smellman @smellman @dkastl we can follow the same convention as in main pgrouting repository, but you need to take account that only master merges are autodeployed at DockerHub. Anyway, we can re-think again the process to deploy Docker images at DockerHub. Actually all autodeploys are failing now with folders rename

https://hub.docker.com/repository/docker/pgrouting/pgrouting/builds

smellman commented 4 years ago

@cayetanobv @dkastl Can you invite me to DockerHub? I want to check build configuration. My docker account is smellman.

cayetanobv commented 4 years ago

@dkastl I can't set permissions to @smellman . Could you do it?

dkastl commented 4 years ago

@smellman , I added your account.

@cayetanobv , that's a bit surprising that you couldn't do this, because I (probably) created a group "Owner" that everyone belongs to, and it should have full control over that organization.

dkastl commented 4 years ago

Screenshot from 2020-02-27 21-17-03

cayetanobv commented 4 years ago

@smellman , I added your account.

@cayetanobv , that's a bit surprising that you couldn't do this, because I (probably) created a group "Owner" that everyone belongs to, and it should have full control over that organization.

Sorry @dkastl , you are right, I can handle permissions. I didn't look at the correct place at DockerHub.

smellman commented 4 years ago

@cayetanobv @dkastl @aruneko I fixes DockerHub settings. If it merged, DockerHub will make new build.

cayetanobv commented 4 years ago

Ok @smellman . I will merge

smellman commented 4 years ago

Thanks!