search

pgRouting / docker-pgrouting

Docker for pgRouting
https://hub.docker.com/repository/docker/pgrouting/pgrouting
GNU General Public License v2.0
64 stars 34 forks source link

Add pgRouting 3.3.2, 3.2.2, 3.1.4, 3.0.6, postgresql-14 and upgrade osm2pgrouting to 2.3.8 #49

Closed krashish8 closed 1 year ago

krashish8 commented 2 years ago

Changes proposed in this pull request:

@pgRouting/admins

krashish8 commented 2 years ago

I have some queries, as I'm updating these Docker images for the first time:

  1. There can be a lot of combinations possible with different pgrouting, postgis, and PostgreSQL versions. Do we update for all such combinations? (I saw that we update only the latest ones, e.g. pgrouting 3.1.3 is present but 3.1.2 is absent)

    • So, I added only the latest docker images for pgrouting 3.0, 3.1, 3.2, and 3.3, skipping any old patch releases.
    • Added them for all the 4 PostgreSQL versions - 11, 12, 13, 14.
    • Only added them for the latest PostGIS v3.2

  2. Do we check whether the docker images are correct or not? If yes, how? I don't see any CI builds/checks present here.

    • We should check just to be sure that, say, a PostGIS version 3.2 is compatible with pgrouting 3.0.6 and with pg14.

  3. I have renamed master to main, and updated the osm2pgrouting version. So, in Dockerhub: all the Docker images need to be updated (because of osm2pgrouting) and the Docker images named "master" need to be deleted, right? (to create the new images named "main")

  4. Maybe we should stop publishing the images for very older versions of pgrouting and PostgreSQL?

    • Otherwise, we need to publish a LOT of images. This PR itself adds 18 new images (2 images for pg14-main and develop, and 16 images for combinations of pg-11,12,13,14 and pgrouting-3.0,3.1,3.2,3.3).

Please review, and do suggest if some changes are required.

cvvergara commented 2 years ago

In https://github.com/pgRouting/docker-pgrouting/pull/49/commits/b9021c6ab96dc8e0e1f22cdd99ee5de452fbdede

I see that you are also changing version 2.x on osm2pgrouting.

We are no longer supporting 2.x I think: do not encourage users to use 2.x

cvvergara commented 2 years ago

marked as draft after #50 is resolved

krashish8 commented 2 years ago

Q: Why are we having different docker images for different pgRouting patch releases? Maybe we can have a single image 12-3.1-3.2 containing the latest patch release 3.2.2, instead of several images 12-3.1-3.2.0, 12-3.1-3.2.1, etc because anyway, users would want to use the latest patch release.

cvvergara commented 2 years ago

@krashish8 sounds reasonable, open an issue with that information.

irwin-uc commented 1 year ago

Why can't Docker pull 13-3.1-3.2.1 ?

krashish8 commented 1 year ago

@irwin-uc This is just a draft PR, probably won't merge now, need to make some changes. Actually, we want to have a single docker image for a minor release rather than several docker images per patch release because anyway, users would want to use the latest patch version. (older patch version might have bugs which is fixed in later patch version)

Refer: https://github.com/pgRouting/docker-pgrouting/issues/53

krashish8 commented 1 year ago

Closing because of #55