Closed sanak closed 1 year ago
Can we close this PR #49 @krashish8 ? I think this was already solved here.
Isn't it necessary to keep the past versions folders in ./backup folder?
I think it is not necessary to do that. We use git for the same purpose - anyone who wants to use these files can go back in history any time using git. If we are no longer maintaining these docker files, maybe we should not keep them. Anyway, there is no issue with keeping these files in the backup folder, so we are good for now.
Is it enough to support recent 3.3 and 3.4 versions?
I think yes, because the last release of 3.2 was last year, and we are no longer maintaining the older releases in pgrouting, aka no bug fixes. So, it is okay if we don't maintain the older releases docker container.
Isn't it necessary to support develop branch, because it seems to be a bit out of date from main branch?
Yes, I think we can support both main and develop branches - useful for those users who want to test the live "development" code but don't want to build from scratch - they can use the Dockerfile for main/develop to use the non-released code. I think this has been taken care of in this PR.
For questions 1 and 2 - I would also add that if we push Docker images in Dockerhub (or any such container library), it will contain the older releases, as normally we won't be deleting those, and anyone wanting to use them could pull them using Dockerhub. We won't be just maintaining the older Dockerfiles in this GitHub repo.
Can we close this PR #49 @krashish8 ? I think this was already solved here.
Yes, @cayetanobv. I have closed that PR.
Thanks for your review @krashish8 . I'm going to merge the PR
@cayetanobv Thanks for merging this PR! šāāļø
@krashish8 Thanks for answering my queries!
I will create another PR which deletes ./backup
folder, later.
Supports #53
@cayetanobv @krashish8 (CC: @cvvergara, @smellman)
Changes proposed in this pull request:
15-3.3-3.4
), this PR keeps to provide pgRouting patch version (ex.15-3.3-3.4.1
) ability as docker tag name by addingversion.txt
in the folder.version.txt
in update.sh.master
tomain
(pick fromupdate.sh
diff in #49).extra/Dockerfile.template
diff in #49)../backup/
. (commit diff:https://github.com/pgRouting/docker-pgrouting/pull/55/commits/d56301351e35345ebd15c00923097ed39a92d2c2)Create/update
postgres=(11 12 13 14 15)
,postgis=(3.3)
andpgrouting=(3.3 3.4 develop main)
combinationsHere is my local work memo:
prepare-versions.sh
file temporarily, then run it (bash prepare-version.sh
).for postgres in "${postgresVersions[@]}"; do for postgis in "${postgisVersions[@]}"; do for pgrouting in "${pgroutingVersions[@]}"; do version="${postgres}-${postgis}-${pgrouting}" mkdir "${version}" touch "${version}/Dockerfile" done done done
README.md
to use new folder structure andversion.txt
and update example from latest tag version.Makefile
to useversion.txt
and create alias (major.minor
version) docker image.I confirmed that
make build
generated all docker images without error in about 4 hours on my Ubuntu 22.04 amd64 desktop PC.Confirmation point
./backup
folder ?develop
branch, because it seems to be a bit out of date frommain
branch ?Original (old) comment
Currently working PR for #53 I still haven't tested `make update` at all, so this is still my trial PR. About fetching latest patch version from pgRouting `major.minor` versions, I referred `docker-library/redmine` repository side, because `postgis/docker-postgis` side seems to depend on debian apt package release. https://github.com/docker-library/redmine/blob/master/update.sh --- - 2022/11/23: I will try minimum test at tomorrow. - 2022/11/25: I will add `version.txt` to store full version for docker tag name's version part (like `15-3.3-3.4.1` in `15-3.3-3.4` folder ,etc.)