search

pgRouting / docker-pgrouting

Docker for pgRouting
https://hub.docker.com/repository/docker/pgrouting/pgrouting
GNU General Public License v2.0
66 stars 34 forks source link

Remove CGAL from v3 #8

Closed cayetanobv closed 2 months ago

cayetanobv commented 5 years ago

Remove CGAL from v3 image according to: https://github.com/pgRouting/pgrouting/pull/1188

cayetanobv commented 4 years ago

I think we can now remove CGAL from Dockerfile templates but we can not generate more pre-v3 versions. What do you think about it?

CC: @dkastl @aruneko @cvvergara @smellman @sanak

sanak commented 4 years ago

@cayetanobv Well, how about to use Dockerfile ARG variable to support both v3 and pre-v3 versions ?
In quite old pgRouting version (2.0), there was -DWITH_DD cmake flag, but in recent case, something like INSTALL_CGAL flag may be good.

+ ARG INSTALL_CGAL=FALSE
:
+ && if [ "${INSTALL_CGAL}" = "TRUE" ]; then apt install -y libcgal%%CDAL_VERSION%% libcgal-dev; fi \

(By the way, CDAL_VERSION should be changed to CGAL_VERSION ?)

I think that -DCMAKE_BUILD_TYPE support may be also interesting. (But, not sure how changing build type affect performance.)

cayetanobv commented 4 years ago

@sanak LGTM

sanak commented 4 years ago

@cayetanobv Okay, thanks for confirmation.

sanak commented 2 years ago

@cayetanobv (CC: @cvvergara) Related with #50, now I think that removing CGAL is no problem.

Here is some related news. https://github.com/pgRouting/pgrouting/issues/1345#issuecomment-1128165167

cayetanobv commented 2 years ago

Yes, I think so

sanak commented 2 months ago

I removed CGAL in PR:#55 (commit:https://github.com/pgRouting/docker-pgrouting/pull/55/commits/be23190bc21ffad28de9dc0d1384fd2350a115d1), so I close this.