search

pgRouting / osm2pgrouting

Import tool for OpenStreetMap data to pgRouting database
https://pgrouting.org
GNU General Public License v2.0
294 stars 111 forks source link

Command line configuration in print outputs (db password) #234

Closed cayetanobv closed 5 years ago

cayetanobv commented 6 years ago

Hi team,

I think we could remove db password from command line print outputs because is not a good thing when you have this application in a production environment (... and this output goes to main logs).

Options to solve this issue: 1) We can remove line 101 of prog_options.cpp file: https://github.com/pgRouting/osm2pgrouting/blob/d10845bffd58c2bb78a030d968dd3ee590bcf7d5/src/utilities/prog_options.cpp#L101 2) We can put a flag to show or not show db password.

I would prefer option 1. @cvvergara @dkastl What do you think about it?

Thanks,

dkastl commented 6 years ago

I think your arguments with the password are valid.

cayetanobv commented 6 years ago

Ok, thanks, PR merged.