search

pgRouting / pgrouting

Repository contains pgRouting library. Development branch is "develop", stable branch is "master"
https://pgrouting.org
GNU General Public License v2.0
1.16k stars 366 forks source link

Add a control on geometrytype for invalid geometries instead of the r… #2461

Closed guyemInc closed 1 year ago

guyemInc commented 1 year ago

Proposal to add a check on geometrytype, in case of invalid geometries, instead of the return

"ERROR: query string argument of EXECUTE is null"

Proposal tested in my postgresql environment before suggestion. @pgRouting/admins

cvvergara commented 1 year ago

@guyemInc can you make the PR towards develop please, We are about to release 3.5, that is on develop. we will not make changes to main at this stage. Maybe by monday 23 if possible. You can either start from scratch from develop or do a cherry pick (otherwise I will do the cherry pick)

cvvergara commented 1 year ago

link to failing action: https://github.com/cvvergara/pgrouting/actions/runs/3942804456

guyemInc commented 1 year ago

Thank you for the positive feedback. I just clicked on "Ready for review". Is that enough to validate Commit ? Or do I need to do other actions ?

guyemInc commented 1 year ago

What do you mean whith "make the PR towards develop "

krashish8 commented 1 year ago

Hey @guyemInc, you can just click on "Edit" button in the top-right corner of this PR and change the base: main to develop. We want to merge the changes in the develop branch, and not the main branch.

guyemInc commented 1 year ago

Ok, thanks, it' done !

If I understand correctly, (it's my first contribution), I cannot perform the merge myself.

Regards