Fix for pg16. Closes #2525

[robe2]

Fixes #2525

Changes proposed in this pull request:

• Use SPI_getvalue directly as it already calls DatumGetCString. DatumGetCString expects a Datum so can not be used here.
• Note this is a new function in develop and note says it's not used, so hard to tell if this change fixed anything, aside from pg16 now being able to compile.

@pgRouting/admins

[robe2]

Just a note, on pg16 testing I am seeing some failures. But might be my windows platform at issue here. I need to retest against PG15 to confirm this is a true PG16 test issue.

Output from my mingw64 setup for PG16 is below just the failed tests

../../pgtap/withPoints/withPointsDD/edge_cases/issue_979.pg                                 (Wstat: 0 Tests: 6 Failed: 1)
  Failed test:  3

Files=479, Tests=53713, 378 wallclock secs ( 2.44 usr  1.75 sys +  2.22 cusr  9.45 csys = 15.86 CPU)
Result: FAIL

[cvvergara]

About the failed test, that I did not fix on the other PR, is supposed to be fixed by a GSoC student. I will get the changes he has done about this.

[cvvergara]

hmmm, maybe I am wrong about which test needs to be checked

[robe2]

Okay I did a pgTap test against my pg15 against develop and that completely passed. So failure seems to be specific to PG16.

I'm going to update my PG16 to latest beta and retest. It could be some issue they had earlier they've since fixed.

[robe2]

I did a test off pg16 against main branch, and sadly some failures but different from the develop ones. Note develop compiles against this pull request but had one failure .

This is main branch failure

../../pgtap/astar/astar/types_check.pg                                                      (Wstat: 0 Tests: 13 Failed: 2)
  Failed tests:  12-13
../../pgtap/bdAstar/bdAstar/types_check.pg                                                  (Wstat: 0 Tests: 13 Failed: 2)
  Failed tests:  12-13