pgRouting / pgrouting

Repository contains pgRouting library. Development branch is "develop", stable branch is "master"
https://pgrouting.org
GNU General Public License v2.0
1.12k stars 364 forks source link

Clang tidy does not work #2614

Closed cvvergara closed 3 months ago

cvvergara commented 4 months ago

While trying to use clang-tidy Tidying headers:

$ clang-tidy -header-filter=./include include/a*/*.h* --  -I/home/path/to/repo/include -isystem /usr/include/postgresql/15/server -I/usr/include/boost/ -I/usr/include
2 errors generated.
Error while processing /home/path/to/repo/include/alphaShape/pgr_alphaShape.h.
2 errors generated.
Error while processing /home/path/to/repo/include/astar/astar.hpp.
/home/path/to/repo/include/alphaShape/pgr_alphaShape.h:34:2: error: This is C++ header file [clang-diagnostic-error]
#error This is C++ header file
 ^
/home/path/to/repo/include/alphaShape/pgr_alphaShape.h:37:10: error: 'vector' file not found [clang-diagnostic-error]
#include <vector>
         ^~~~~~~~
Found compiler error(s). 

The reason for this failure is that pgr_alphaShape.h should be an hpp file

Renaming of h to hpp is needed on files like this one

TODO

List of directories containing .h files that probably need to be changed to .hpp files