pgRouting / pgrouting

Repository contains pgRouting library. Development branch is "develop", stable branch is "master"
https://pgrouting.org
GNU General Public License v2.0
1.12k stars 364 forks source link

Remove bool from definition of a graph #2634

Closed cvvergara closed 2 months ago

cvvergara commented 2 months ago

Up to version 3.6 this has been used and it is redundant The false means that the graph is undirected, and the name has undirected

pgrouting::UndirectedGraph undigraph(false);

Change to

pgrouting::UndirectedGraph undigraph;

Avoids possible errors like

pgrouting::UndirectedGraph undigraph(true);
pgrouting::DirectedGraph undigraph(false);

BTW while doing this, a bug about pgr_lineGraph was found. Will open an issue later on describing the issue. But the work to fix it has been started. on #2625