search

pgRouting / pgrouting

Repository contains pgRouting library. Development branch is "develop", stable branch is "master"
https://pgrouting.org
GNU General Public License v2.0
1.17k stars 368 forks source link

Fail building under window mingw64 #2648

Closed robe2 closed 1 month ago

robe2 commented 1 month ago

Just noticed that winnie has been failing for some time compiling develop.

https://winnie.postgis.net/job/pgRouting_PGVersionEDB/10537/console

Issue is repeated multiple times like below, but all errors seem to be around the new functionality betweennessCentrality

/src/metrics/betweennessCentrality_driver.cpp:37 (on line 32 or 37)

In file included from E:/jenkins/postgresql/rel/pg16w64gcc81/include/server/port/win32_port.h:75, from E:/jenkins/postgresql/rel/pg16w64gcc81/include/server/port.h:24, from E:/jenkins/postgresql/rel/pg16w64gcc81/include/server/c.h:1375, from E:/jenkins/postgresql/rel/pg16w64gcc81/include/server/postgres.h:45, from E:/jenkins/pgrouting/branches/develop/include/cpp_common/pgdata_getters.hpp:42, from E:/jenkins/pgrouting/branches/develop/src/metrics/betweennessCentrality_driver.cpp:37: C:/ming64gcc81/mingw64/x86_64-w64-mingw32/include/sys/stat.h: In function 'int microsoft_native_fstat(int, microsoft_native_stat*)': C:/ming64gcc81/mingw64/x86_64-w64-mingw32/include/sys/stat.h:226:38: error: invalid application of 'sizeof' to incomplete type 'microsoft_native_stat' memset(_Stat,0,sizeof(struct stat)); ^

cvvergara commented 1 month ago

Found a similar problem in PostGIS https://trac.osgeo.org/postgis/ticket/4877 Right now I am figuring out how it was fixed.

robe2 commented 1 month ago

Winnie is green now for pgrouting develop except for the PG12 run, which we concluded is broken for all PG 12. That doesn't need fixing if we release 3.7.0 after PG 12 reaches end of life this coming November 14th 2024 - https://www.postgresql.org/support/versioning/

robe2 commented 1 month ago

since we are not supporting PG12 the PG12 error is moot.