pgRouting / pgrouting

Repository contains pgRouting library. Development branch is "develop", stable branch is "master"
https://pgrouting.org
GNU General Public License v2.0
1.17k stars 367 forks source link

pgRouting SQL coding standard for documents and examples #386

Open sanak opened 9 years ago

sanak commented 9 years ago

PostGIS documents seem to be written by a certain rule (ST_XyzAbc and upper case SQL words .etc). Should we follow the SQL coding standard except pgRouting function name (pgr_xyzAbc .etc) ?

robe2 commented 9 years ago

Probably not worth the effort. The reason PostGIS does that is to satisfy SQL/MM convention (and then we said might as well make all our functions that way even if they aren't SQL/MM to minimize on confusion). Since your functions aren't SQL/MM defined, you have no precedence for it. You just need to be consistent within your own functions/documentation which I think you are.

sanak commented 9 years ago

Okay. Thanks for confirmation. (I forgot that SQL/MM is OGC standard...)

I found some inconsistencies in pgr_alphaShape and pgr_pointsAsPolygon documents. So, I will keep this status as opened for another function documents for a while.

woodbri commented 9 years ago

I think that we roughly were mimicing the postgis style because we are dependent on postgis so again just trying to be consistent. I don't think we are rigid about this or have even documented that we have a style. We might want to add a style guide statement to the development standards docs.

sanak commented 9 years ago

@woodbri Okay. Thanks for comment.

cvvergara commented 8 years ago

Eventually we need a pgRouting standard on function names:

But I think also it will need a full review of how the family of functions are formed A for versions 2.x all new families of functions are proposed, then before 3.0 this can be reviewed and make the standard.

cvvergara commented 8 years ago

400 is related