search

pgRouting / pgrouting

Repository contains pgRouting library. Development branch is "develop", stable branch is "master"
https://pgrouting.org
GNU General Public License v2.0
1.12k stars 364 forks source link

Duplicate log output by cmake #582

Closed dkastl closed 7 years ago

dkastl commented 8 years ago

When you run cmake .. the log output looks pretty nice, though a lot of information seems to be duplicate.

Example:

$ cmake  ..
-- The C compiler identification is GNU 5.3.1
-- The CXX compiler identification is GNU 5.3.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done

Do we always need Detecting followed by an identical line ending with -done? Can we get rid of this?

-- CMAKE_VERSION: 3.5.1
-- PGROUTING_GIT_TAG: pgrouting-2.2.3
-- PGROUTING_GIT_BUILD: 2.2.3
-- PGROUTING_GIT_HASH: 6d05b9b
-- PGROUTING_GIT_BRANCH: master
-- PGROUTING_VERSION_REVISION_NAME: 6d05b9b master
-- PGROUTING_SOURCE_DIR: /home/daniel/Repository/pgRouting/pgrouting
-- CMAKE_BINARY_DIR: /home/daniel/Repository/pgRouting/pgrouting/build
-- PGROUTING_VERSION_REVISION_HASH: 6d05b9b

We have the same HASH already defined before.

-- POSTGRESQL_BIN:

No PostgreSQL BIN?

-- UNIX=1
-- WIN32=
-- Found Perl: /usr/bin/perl (found version "5.22.1") 
-- POSTGRESQL_PG_CONFIG is /usr/bin/pg_config
-- POSTGRESQL_EXECUTABLE is /usr/lib/postgresql/9.3/bin/postgres
-- POSTGRESQL_VERSION_STRING in FindPostgreSQL.cmake is PostgreSQL 9.5.3
-- POSTGRESQL_INCLUDE_DIR: /usr/include/postgresql/9.3/server
-- POSTGRESQL_LIBRARIES: /usr/lib/x86_64-linux-gnu
-- Boost version: 1.58.0
-- Boost headers were found here: /usr/include
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE  
-- Boost version: 1.58.0
-- Found the following Boost libraries:
--   thread
--   chrono
--   system
--   date_time
--   atomic
-- Boost version: 1.58.0
-- Found the following Boost libraries:
--   thread
--   system
--   chrono
--   date_time
--   atomic

Lots of duplication with Boost!

-- CGAL_INCLUDE_DIR=/usr/include
-- CGAL_LIBRARIES=/usr/lib/libCGAL.so
-- BOOST_THREAD_LIBRARIES=/usr/lib/x86_64-linux-gnu/libboost_thread.so;/usr/lib/x86_64-linux-gnu/libboost_system.so;/usr/lib/x86_64-linux-gnu/libboost_chrono.so;/usr/lib/x86_64-linux-gnu/libboost_date_time.so;/usr/lib/x86_64-linux-gnu/libboost_atomic.so;/usr/lib/x86_64-linux-gnu/libpthread.so

Boost comes here again.

-- GMP_LIBRARIES=/usr/lib/x86_64-linux-gnu/libgmp.so
-- Found CGAL: /usr/include, /usr/lib/libCGAL.so, /usr/lib/x86_64-linux-gnu/libboost_thread.so;/usr/lib/x86_64-linux-gnu/libboost_system.so;/usr/lib/x86_64-linux-gnu/libboost_chrono.so;/usr/lib/x86_64-linux-gnu/libboost_date_time.so;/usr/lib/x86_64-linux-gnu/libboost_atomic.so;/usr/lib/x86_64-linux-gnu/libpthread.so, /usr/lib/x86_64-linux-gnu/libgmp.so
-- POSTGRESQL_VERSION_STRING is PostgreSQL 9.5.3
-- POSTGRESQL_VERSION is 9.5.3
-- PGSQL_VERSION is 95

PostgreSQL was already mentioned several lines before. Why do we need POSTGRESQL_VERSION and PGSQL_VERSION?

-- Install directory for libraries is set to /usr/lib/postgresql/9.5/lib
-- Extension directory for SQL files is set to /usr/share/postgresql/9.5/extension
/home/daniel/Repository/pgRouting/pgrouting/src/common/sql/pgrouting-types.sql
/home/daniel/Repository/pgRouting/pgrouting/src/common/sql/pgrouting_version.sql
/home/daniel/Repository/pgRouting/pgrouting/src/common/sql/pgrouting_utilities.sql
/home/daniel/Repository/pgRouting/pgrouting/src/common/sql/pgr_parameter_check.sql
/home/daniel/Repository/pgRouting/pgrouting/src/common/sql/utilities_pgr.sql
/home/daniel/Repository/pgRouting/pgrouting/src/common/sql/noUnderUtilities.sql
/home/daniel/Repository/pgRouting/pgrouting/src/common/sql/createIndex.sql
/home/daniel/Repository/pgRouting/pgrouting/src/common/sql/_point_toId.sql
/home/daniel/Repository/pgRouting/pgrouting/src/kdijkstra/sql/kdijkstra-V2.2.sql
/home/daniel/Repository/pgRouting/pgrouting/src/dijkstra/sql/dijkstra.sql
/home/daniel/Repository/pgRouting/pgrouting/src/dijkstra/sql/dijkstraCost.sql
/home/daniel/Repository/pgRouting/pgrouting/src/dijkstra/sql/dijkstraVia.sql
/home/daniel/Repository/pgRouting/pgrouting/src/driving_distance/sql/withPoints_dd.sql
/home/daniel/Repository/pgRouting/pgrouting/src/driving_distance/sql/routing_dd.sql
/home/daniel/Repository/pgRouting/pgrouting/src/ksp/sql/routing_ksp.sql
/home/daniel/Repository/pgRouting/pgrouting/src/ksp/sql/withPoints_ksp.sql
/home/daniel/Repository/pgRouting/pgrouting/src/allpairs/sql/johnson.sql
/home/daniel/Repository/pgRouting/pgrouting/src/allpairs/sql/floydWarshall.sql
/home/daniel/Repository/pgRouting/pgrouting/src/withPoints/sql/withPoints.sql
/home/daniel/Repository/pgRouting/pgrouting/src/withPoints/sql/withPointsCost.sql
/home/daniel/Repository/pgRouting/pgrouting/src/withPoints/sql/withPointsVia.sql
/home/daniel/Repository/pgRouting/pgrouting/src/alpha_shape/sql/alpha_shape.sql
/home/daniel/Repository/pgRouting/pgrouting/src/astar/sql/astar.sql
/home/daniel/Repository/pgRouting/pgrouting/src/bd_astar/sql/routing_bd_astar.sql
/home/daniel/Repository/pgRouting/pgrouting/src/bd_dijkstra/sql/routing_bd_dijkstra.sql
/home/daniel/Repository/pgRouting/pgrouting/src/trsp/sql/vias_trsp_V2.2.sql
/home/daniel/Repository/pgRouting/pgrouting/src/trsp/sql/trsp_V2.2.sql
/home/daniel/Repository/pgRouting/pgrouting/src/tsp/sql/routing_tsp.sql
/home/daniel/Repository/pgRouting/pgrouting/src/tsp/sql/routing_tsp_wrappers.sql
/home/daniel/Repository/pgRouting/pgrouting/src/vrp_basic/sql/routing_vrp.sql
/home/daniel/Repository/pgRouting/pgrouting/src/vrppdtw/sql/routing_vrppdtw.sql
/home/daniel/Repository/pgRouting/pgrouting/src/apsp_johnson/sql/apsp_johnson_v2.2.sql
/home/daniel/Repository/pgRouting/pgrouting/src/apsp_warshall/sql/apsp_warshall_v2.2.sql
/home/daniel/Repository/pgRouting/pgrouting/src/convinience/sql/pgrouting_conversion_tools.sql
/home/daniel/Repository/pgRouting/pgrouting/src/convinience/sql/pgrouting_dmatrix_tools.sql
/home/daniel/Repository/pgRouting/pgrouting/src/convinience/sql/pgr_vidsToDMatrix_dir.sql
/home/daniel/Repository/pgRouting/pgrouting/src/topology/sql/pgrouting_topology.sql
/home/daniel/Repository/pgRouting/pgrouting/src/topology/sql/pgrouting_analytics.sql
/home/daniel/Repository/pgRouting/pgrouting/src/topology/sql/create_vertices_table.sql
/home/daniel/Repository/pgRouting/pgrouting/src/topology/sql/nodeNetwork.sql
/home/daniel/Repository/pgRouting/pgrouting/src/label_graph/sql/label_graph.sql
Building the library names
-- Creating lib/pgrouting--2.2.3.sig
-- LIBS_TO_INSTALL=
-- Configuring done
-- Generating done
-- Build files have been written to: /home/daniel/Repository/pgRouting/pgrouting/build

What means LIBS_TO_INSTALL?

cvvergara commented 8 years ago

I agree, cmake needs a lot of cleaning.

cvvergara commented 7 years ago

With pull request #705 building log is much smaller https://travis-ci.org/pgRouting/pgrouting/jobs/182395398#L375