pgRouting / pgrouting

Repository contains pgRouting library. Development branch is "develop", stable branch is "master"
https://pgrouting.org
GNU General Public License v2.0
1.12k stars 364 forks source link

Too much deprecated functions documentation to mantain #757

Closed cvvergara closed 7 years ago

cvvergara commented 7 years ago

During the v2.x series, the deprecated functions documentation has being keep around "for reference". For example the deprecated function like pgr_getColumnName that has no replacement and that was deprecated on 2.1: The function has to be kept for backwards compatability. But does that mean that the link to the documentation has to be made if its deprecated and no longer mantained? I think keeping the documentation of the function encourages people to keep using it.

Change wrapper (That use the replacement when there is one) Update news Update change Log Add to deprecated.rst the deprecated one(s) Add to Proposed functions the new signature(s) Modify the documented results given by the new algorithms on the old documentation Update links. etc Make sure they don't show up in the index

So basically I want to get rid of the following section(s) on the documentation:

http://docs.pgrouting.org/2.4/en/doc/index.html#discontinued-deprecated-functions http://docs.pgrouting.org/2.4/en/doc/src/developer/discontinued.html#discontinued http://docs.pgrouting.org/2.4/en/doc/deprecated.html

Together with the documentation of the deprecated functions.

Task I think would be:

robe2 commented 7 years ago

I think you should get rid of deprecated functions. People have enough trouble keeping track of what they should be using without having to worry about what they should not be using.

If it's not documented, don't use it, should be the motto.

cvvergara commented 7 years ago

Made a demo of a Migration guide, for example, imagine that pgr_bdAstar is rewritten on 2.5 Then the migration guide would look like: https://github.com/cvvergara/pgrouting/wiki/Migration-Guide

woodbri commented 7 years ago

This looks very good. Nice job!

dkastl commented 7 years ago

What about having some sort of "Landing Page", which could be https://github.com/cvvergara/pgrouting/wiki/Migration-Guide On this page would be a table of contents with links to Wiki Pages like the one mentioned, for example:

The advantage of this approach would be, that a) the Migration Wiki page doesn't get too long with new releases, and b) we can keep the link the same.

dkastl commented 7 years ago

If you think it looks "too empty", the Migration Guide page could contain some general advice like how to make a data backup before upgrading.

cvvergara commented 7 years ago

I was thinking more on: Only one migration page, with an index at the top for fast navigation and the most resent migration at the top. The migrations are accumulative. The link I posted is in my fork just for a demo, (style, contents) The landing page shall be in the main repo wiki

cvvergara commented 7 years ago

@dkastl advantage of being in a wiki .... We can add any advise that we see fit

dkastl commented 7 years ago

Yes, Wiki sounds good for that purpose. I'm usually in favor or shorter linked pages and couldn't find a way to automatically generated a table of content for example. But I'm not strongly against a single page either. I just thought it's easier to maintain and to find information in it.

cvvergara commented 7 years ago

with an "good" index at the top will be fine, I'll start making it, we can then evaluate how it "grows" and see if breaking it into different pages is needed.

cvvergara commented 7 years ago

@dkastl Can you have a look? (it has an index) https://github.com/pgRouting/pgrouting/wiki/Migration-Guide

cvvergara commented 7 years ago

Simplified a lot the documentation by removing the documentatio of deprecated functions