cmake version required version number wrong

pgRouting / pgrouting

Repository contains pgRouting library. Development branch is "develop", stable branch is "master"

https://pgrouting.org

GNU General Public License v2.0

1.15k stars 366 forks source link

cmake version required version number wrong #948

Closed smathermather closed 6 years ago

smathermather commented 7 years ago

Expected behavior and actual behavior

When running cmake with version 2.8.12.2, it fails on "continue".

Steps to reproduce the problem

Install cmake 2.8.12.2 on Ubuntu 14.04. Try to build pgRouting

Other info

cmake 2.8.12.2 doesn't have "continue" per https://github.com/BioMedIA/MIRTK/issues/197 . README.md could be updates to reflect current minimum for cmake to fix issue.

cvvergara commented 7 years ago

cmake 3.2 would be the minimum version of cmake (I think) That means modify readme, some docs, and the CMakeLists probably it also needs a new micro release. @robe2 doing these changes needs imply to make a new micro release?

robe2 commented 7 years ago

@cvvergara it's such a small change that affects few people that I wouldn't rush to put out a 2.5.1 for it.

But yes it would require a micro release at any rate.

dkastl commented 7 years ago

I agree with @robe2 : let's collect a few more issues until making a 2.5.1 release.

smathermather commented 7 years ago

👍