search

pgadmin-org / pgadmin3

Archive of the pgAdmin III project
https://www.pgadmin.org/
Other
177 stars 82 forks source link

'truncate table' dialog type changed to OK|CANCEL #3

Closed nikicat closed 11 years ago

nikicat commented 11 years ago

'truncate table' dialog type changed to OK|CANCEL to avoid table truncate when pressing keyboard Esc button. See https://groups.google.com/forum/?fromgroups#!topic/wx-users/eNG0k5ajlEQ

nikicat commented 11 years ago

Hi, @gleu! Would you review this request?

gleu commented 11 years ago

It seems you're right. I'm currently working on it. Will commit ASAP.

gleu commented 11 years ago

OK, so it seems this issue was rather common inside pgAdmin source code. I rewrote your patch to take care of all the other faulty checks. See my last commit for more informations.

Anyway, thanks for your patch, and your message. It helped us fix a quite awful and widespread bug.

nikicat commented 11 years ago

Thanks a lot, @gleu My co-worker accidentally truncated important tables in production database several times because of this bug. I think he will be happy after next upgrade of his distro's pgAdmin package.

gleu commented 11 years ago

You're welcome. That sort of things should never happened.

repo-lockdown[bot] commented 5 years ago

Thanks for your Pull Request! :smile: This repo on GitHub is just a mirror of our real git repositories though, and can't really handle PRs. :frowning: Hopefully you can redo the PR, and direct it to the git.postgresql.org repos? We have a developer guide, if that helps: https://wiki.postgresql.org/wiki/So,_you_want_to_be_a_developer%3F. If this was a PR for pgAdmin, please visit https://www.pgadmin.org/docs/pgadmin4/dev/submitting_patches.html.