pgadmin-org / pgadmin3

Archive of the pgAdmin III project
https://www.pgadmin.org/
Other
178 stars 82 forks source link

Enum only showing as array type in new function dialog (RM #604) #375

Closed dpage closed 2 years ago

dpage commented 12 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/604 Originally created by Anonymous at 2012-04-17 07:15:58 UTC.

In the dialog to create a new function, under "Definition" as well as under "Parameters", enum types seem only to be available as array types - with a [] appended. Like: mytype[]. But no: mytype.

Came up here: http://stackoverflow.com/questions/10178402/pgadmin-iii-showing-type-but-not-type

I tested and verified this with 1.14.2.

dpage commented 12 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/604#note-1 Originally created by Guillaume Lelarge at 2012-04-18 21:28:44 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
dpage commented 12 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/604#note-2 Originally created by Guillaume Lelarge at 2012-04-18 21:38:19 UTC.

Fixed in http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=d6e4c1fd835e7762cc9eef5b10641c29803dd1a1 and http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=cfe0a7ffd13fd7c30c28341a66a16c8d9fc3530c.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress Resolved
Resolution changed fixed
dpage commented 12 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/424 Originally created by Anonymous at 2012-06-18 23:08:24 UTC.

enum_bug.jpg

Filename: enum_bug.jpg

Description: basic enum type missing, only array type shown

dpage commented 12 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/604#note-4 Originally created by Anonymous at 2012-06-18 23:10:48 UTC.

Still present in v1.14.3 (see attached screenshot).

It seems fixed in v1.16 beta2, though.

Redmine ticket header update:

Name Old Value New Value
Status changed Resolved Rejected
Resolution changed fixed
dpage commented 12 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/604#note-5 Originally created by Guillaume Lelarge at 2012-06-19 13:45:50 UTC.

Works for me. You'll definitely need more than simply this to convince me it doesn't work. I applied the exact same patch, there was nothing more applied on pgadmin/dlg/dlgFunction.cpp after that patch, and it works for me right now.

dpage commented 12 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/604#note-6 Originally created by Anonymous at 2012-06-20 13:02:11 UTC.

I retested and found that it, in fact, works in 1.14.3 fort me, too. Not sure how I got confused, maybe I installed 1.16 and forgot to upgrade 1.14.2 -> 1.14.3 on my other machine before the test. Closing the bug, I am very sorry for the noise.

Redmine ticket header update:

Name Old Value New Value
Status changed Rejected Resolved
Resolution changed fixed
dpage commented 2 years ago

Issue closed on Redmine.