search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.53k stars 656 forks source link

Error highlighting broken (RM #2291) #1079

Closed dpage closed 2 years ago

dpage commented 7 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/2291 Originally created by Dave Page at 2017-03-24 14:41:16 UTC.

If you run an invalid query in the Query Tool, the error messages is returned, but the error line and word are no longer highlighted in CodeMirror as they used to be.

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2291#note-1 Originally created by Khushboo Vashi at 2017-03-31 06:53:45 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Khushboo Vashi
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2291#note-2 Originally created by Khushboo Vashi at 2017-03-31 07:15:54 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2291#note-3 Originally created by Khushboo Vashi at 2017-03-31 09:55:05 UTC.

Patch submitted.

https://www.postgresql.org/message-id/CAFOhELdgyD60029qfNPzg74H4-ubsb7QMoeO2O2Wd3FXmAtouw@mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2291#note-4 Originally created by Khushboo Vashi at 2017-04-01 06:43:05 UTC.

Applied in changeset commit:efb077b7f77f6313bb4b67aa3ffb27a65e296330.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2291#note-5 Originally created by Fahar Abbas at 2017-04-03 06:43:28 UTC.

This issue is resolved in latest commit ID:

Commit ID: commit bb0bd8acc5d6899ed514159e344928e6453faa63

Tested Platform: Ubuntu 16.04(Python 3.5) Windows 2012 R2 64(python 2.7.13)

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2291#note-6 Originally created by Fahar Abbas at 2018-01-09 05:32:43 UTC.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.