search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.43k stars 638 forks source link

Add a context menu option to manually (re)count rows in tables, including those with >2K rows (RM #2846) #1469

Closed dpage closed 2 years ago

dpage commented 6 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/2846 Originally created by Dave Page at 2017-11-02 13:38:26 UTC.

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2846#note-1 Originally created by Khushboo Vashi at 2017-11-03 05:16:14 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Khushboo Vashi
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2846#note-2 Originally created by Khushboo Vashi at 2017-11-06 06:28:33 UTC.

Hi Dave,

I need some clarification on this task.

As per my understanding, we need a context menu "Count" for a table which will count the actual rows of a table. it will display the actual number if the estimated rows is less than the threshold value set by the user otherwise threshold value+.

This functionality is already implemented and we are getting the number while clicking on the node. It will also update same if the count of the rows is updated once we click the node. So, why we need separate "Count" menu for a table?

Thanks, Khushboo

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress New
Assigned To changed Khushboo Vashi Dave Page
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2846#note-3 Originally created by Dave Page at 2017-11-06 14:26:20 UTC.

We need a count option because if the estimated rows exceeds the threshold, then we don't explicitly count the rows in the table. The estimate may be wrong though - or the user may want an exact count, so by adding the menu option, the user can always get the correct row count.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Dave Page Khushboo Vashi
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2846#note-4 Originally created by Khushboo Vashi at 2017-11-07 11:02:30 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2846#note-5 Originally created by Khushboo Vashi at 2017-11-07 12:23:22 UTC.

The patch submitted. https://www.postgresql.org/message-id/CAFOhELdpXGc+bpUq1w7mLidF7jf9fPEGtqC4ywXmcEHow8s7ZQ@mail.gmail.com

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2846#note-6 Originally created by Khushboo Vashi at 2017-11-08 01:27:16 UTC.

Applied in changeset commit:88cd68c2b9a626eee0e29242aa8ca4401a3999b6.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2846#note-7 Originally created by Fahar Abbas at 2017-11-16 07:32:39 UTC.

Tested Platform: MAC 10.12(Python 3.6) Ubuntu 14.04(Python 3.5)

Commit ID:

commit 96df3147d632d9bc385df1c6d62b4f0242b650c6

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2846#note-8 Originally created by Fahar Abbas at 2018-01-09 05:55:47 UTC.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.