pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.53k stars 658 forks source link

[Desktop Runtime] pgAdmin4 crash if user download query as CSV (RM #2964) #1559

Closed dpage closed 2 years ago

dpage commented 6 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/2964 Originally created by Fahar Abbas at 2017-12-19 05:30:10 UTC.

Tested Platform: MAC 10.12 Windows 08 64 Tested Build: https://developer.pgadmin.org/~dpage/2.1-dev/

Steps

  1. Install PG-10, select all components except pgAdmin4
  2. PG-10 installed successfully
  3. Install pgAdmin4 community installer
  4. Launch pgAdmin4
  5. Click on database postgres
  6. Click query tool windows
  7. write query select * from version and execute this command
  8. Click on download query as CVS
  9. pgAdmin4 crashed

Expected Result:

Query should be downloaded successfully

dpage commented 6 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/2715 Originally created by Fahar Abbas at 2017-12-19 05:29:53 UTC.

https://pgadmin-archive.postgresql.org/redmine/2964/2715-1.png

dpage commented 6 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/2716 Originally created by Fahar Abbas at 2017-12-19 05:29:56 UTC.

https://pgadmin-archive.postgresql.org/redmine/2964/2716-2.png

dpage commented 6 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/2717 Originally created by Fahar Abbas at 2017-12-19 05:30:00 UTC.

https://pgadmin-archive.postgresql.org/redmine/2964/2717-3.png

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-4 Originally created by Fahar Abbas at 2017-12-19 05:30:50 UTC.

Redmine ticket header update:

Name Old Value New Value
Subject changed [Desktop Runtime] pgAdmin4 crash if user download if download query as CVS [Desktop Runtime] pgAdmin4 crash if user download query as CVS
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-5 Originally created by Khushboo Vashi at 2017-12-19 05:59:29 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Khushboo Vashi
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-6 Originally created by Khushboo Vashi at 2017-12-19 06:34:02 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 3
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-7 Originally created by Khushboo Vashi at 2017-12-19 06:34:19 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-8 Originally created by Fahar Abbas at 2017-12-19 06:47:41 UTC.

Redmine ticket header update:

Name Old Value New Value
Subject changed [Desktop Runtime] pgAdmin4 crash if user download query as CVS [Desktop Runtime] pgAdmin4 crash if user download query as CSV
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-9 Originally created by Khushboo Vashi at 2017-12-19 06:52:56 UTC.

Patch submitted. https://www.postgresql.org/message-id/CAFOhELfnWqcWW+oMkfovCiQyiKCpF9iSMqB=fhekvgkZmY188Q@mail.gmail.com

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-10 Originally created by Neel Patel at 2017-12-19 12:20:06 UTC.

Applied in changeset commit:90f5af890253a3170dfd1f08f639d171e0e7a871.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-11 Originally created by Dave Page at 2017-12-19 12:20:29 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 2.1
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-12 Originally created by Neel Patel at 2018-01-03 12:54:52 UTC.

Applied in changeset commit:b5813fd438eb330fc86b88e426c7de61fe1379ae.

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-13 Originally created by Fahar Abbas at 2018-01-08 05:32:54 UTC.

Will verify this RM in Next Community Build for pgAdmin4.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Khushboo Vashi Fahar Abbas
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2964#note-14 Originally created by Fahar Abbas at 2018-01-10 12:30:57 UTC.

This is already resolved in community build for 2.1.

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.