Closed dpage closed 2 years ago
dpage
commented
6 years ago Comment migrated from Redmine: https://redmine.postgresql.org/issues/3134#note-1 Originally created by Khushboo Vashi at 2018-03-09 10:52:22 UTC.
Dave,
Please have a look.
Thanks, Khushboo
Redmine ticket header update:
| Name | Old Value | New Value |
|---|---|---|
| Assigned To changed | Dave Page |
dpage
commented
6 years ago Comment migrated from Redmine: https://redmine.postgresql.org/issues/3134#note-2 Originally created by John Harvey at 2018-04-30 14:55:05 UTC.
Hello folks,
I just validated that the problem still exists with pgadmin4 3.0. The font-mfizz files are still in there. I might suggest raising the priority a little bit because the source tarball that's getting released is dirty and not reproducible.
Below is the current list of differences:
web/pgadmin/static/js/generated/app.bundle.js.map web/pgadmin/static/js/generated/core.css.map web/pgadmin/static/js/generated/core.js web/pgadmin/static/js/generated/debugger_direct.js.map web/pgadmin/static/js/generated/file_utils.js.map web/pgadmin/static/js/generated/fonts/font-mfizz.eot web/pgadmin/static/js/generated/fonts/font-mfizz.svg web/pgadmin/static/js/generated/fonts/font-mfizz.ttf web/pgadmin/static/js/generated/fonts/font-mfizz.woff web/pgadmin/static/js/generated/history.js web/pgadmin/static/js/generated/img/font-mfizz.svg web/pgadmin/static/js/generated/pgadmin_commons.js.map web/pgadmin/static/js/generated/pgadmincss.css web/pgadmin/static/js/generated/pgadmincss.js web/pgadmin/static/js/generated/reactComponents.js web/pgadmin/static/js/generated/react.js web/pgadmin/static/js/generated/slickgrid.js web/pgadmin/static/js/generated/sqleditor.js.map web/pgadmin/static/js/generated/vendor.css.map
Regards, -John
dpage
commented
6 years ago Comment migrated from Redmine: https://redmine.postgresql.org/issues/3134#note-3 Originally created by Dave Page at 2018-04-30 15:13:54 UTC.
Applied in changeset commit:ae1b2149a1c87429f1024e2aa41bd29e2e0f3dbe.
Redmine ticket header update:
| Name | Old Value | New Value |
|---|---|---|
| Status changed | New | In Testing |
| Done Ratio changed | 0 | 90 |
dpage
commented
6 years ago Comment migrated from Redmine: https://redmine.postgresql.org/issues/3134#note-4 Originally created by Fahar Abbas at 2018-05-03 04:40:51 UTC.
Commit ID:
commit 59d8f6fb84e0aabc098fecf968cde3f9fcdf53b0
Tested Platform: Windows 2012 R2 64(Python 2.7)
Redmine ticket header update:
| Name | Old Value | New Value |
|---|---|---|
| Status changed | In Testing | Resolved |
| Done Ratio changed | 90 | 100 |
dpage
commented
2 years ago Issue closed on Redmine.
Issue migrated from Redmine: https://redmine.postgresql.org/issues/3134 Originally created by John Harvey at 2018-02-19 16:27:04 UTC.
In the pgadmin4 v2.1 release, there are some obsolete files have made their way into the source tarball.
These files include: a) font-mfizz files, which were removed before pgadmin4 v2.0 b) Nine files in web/pgadmin/static/js/generated: core.css.map core.js history.js pgadmincss.css pgadmincss.js reactComponents.js react.js slickgrid.js vendor.css.map
It appears some items from make bundle-dev may have incorrectly been packaged as well, even though they should not have been included.
I asked Dave Page if he had any ideas, and he mentioned that it looked like the generated files were being copied straight from the original source tree by pkg/src/build.sh. That may be inadvertently copying obsolete files as well. If so, that script would need to be modified to make sure that the end source tarball is generated from clean source each time.
If any more information is required, please let me know.
Thanks!