search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.53k stars 656 forks source link

pgadmin4 does not start if user change the language to Japanese and server restarted (RM #3303) #1807

Closed dpage closed 2 years ago

dpage commented 6 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/3303 Originally created by Taiki Terauchi at 2018-04-19 16:02:06 UTC.

Commit ID:

0493b86d4d4e53e5bdfcb08c4b5eb771302a88a9

Platform: Windows 10(Python 2.7.13)

Steps:

  1. Launch pgAdmin4
  2. go into preferences and change language to Japanese
  3. shutdown server
  4. Launch pgAdmin4
  5. error dialog is displayed

Error dialog Message:

Dialog Title: Fatal Error
Dialog Message: The application server could not be contacted.

Error log: See attached file pgadmin4.log.

I modified the translation file so that it can be launched.

The cause of startup failure was "%" (half size). As a provisional correspondence, we fixed it to "％" (full-width).

dpage commented 6 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/2976 Originally created by Taiki Terauchi at 2018-04-19 15:45:20 UTC.

https://pgadmin-archive.postgresql.org/redmine/3303/2976-messages.mo

dpage commented 6 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/2977 Originally created by Taiki Terauchi at 2018-04-19 15:45:20 UTC.

https://pgadmin-archive.postgresql.org/redmine/3303/2977-messages.po.diff

dpage commented 6 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/2978 Originally created by Taiki Terauchi at 2018-04-19 15:45:20 UTC.

https://pgadmin-archive.postgresql.org/redmine/3303/2978-pgadmin4.log

dpage commented 6 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/2979 Originally created by Taiki Terauchi at 2018-04-19 15:45:21 UTC.

https://pgadmin-archive.postgresql.org/redmine/3303/2979-messages.po

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-5 Originally created by Murtuza Zabuawala at 2018-04-20 06:09:50 UTC.

Hi Taiki Terauchi,

Could you please send your patch to pgadmin-hackers@postgresql.org email group?

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-6 Originally created by Dave Page at 2018-04-20 08:10:50 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 3.1
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-7 Originally created by Taiki Terauchi at 2018-04-20 08:12:07 UTC.

Applied in changeset commit:51cc7c1e337b8bc882a6d14339692074ab8ed218.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Testing
Done Ratio changed 0 90
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-8 Originally created by Murtuza Zabuawala at 2018-04-20 08:31:14 UTC.

Redmine ticket header update:

Name Old Value New Value
Relationship (duplicates) changed RM #3252
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-9 Originally created by Dave Page at 2018-04-20 08:50:16 UTC.

I had to modify this patch again as it was failing to load the preferences panel with the original fix. Gettext really doesn't seem to like % symbols :-(.

I changed it to: 20パーセント

I hope that works.

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-10 Originally created by Dave Page at 2018-04-20 09:04:45 UTC.

Duplicate ticket.

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Rejected
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-11 Originally created by Taiki Terauchi at 2018-04-20 11:07:39 UTC.

Hi Murtuza Zabuawala, Oh Sorry. We will send the patch later on the mailing list.

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-12 Originally created by Taiki Terauchi at 2018-04-20 11:19:31 UTC.

Hi Dave Page, Thank you for making a beautiful fix.

Changing "%" to "％" was not the best.

I first realized that "%" is not compatible with Gettext:-(

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-13 Originally created by Taiki Terauchi at 2018-04-20 13:03:40 UTC.

I commented to send the patch to the mailing list, but it was already merged. thank you.

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-14 Originally created by Dave Page at 2018-06-27 10:45:45 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed Rejected In Progress
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-15 Originally created by Dave Page at 2018-06-27 10:50:12 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-16 Originally created by Dave Page at 2018-06-27 10:50:38 UTC.

Fixed in commit:6ca07528ff1fd6e26b73d3fbc642516cdc2db593

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3303#note-17 Originally created by Fahar Abbas at 2018-06-28 07:19:17 UTC.

This is already resolved in updated runtime installers.

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.