Deleting a row in the query tool fails silently if constraints prevent it (RM #3310)

[dpage]

Issue migrated from Redmine: https://redmine.postgresql.org/issues/3310 Originally created by Dave Page at 2018-04-25 08:56:46 UTC.

If a row cannot be deleted (e.g. because it would violate a foreign key constraint), the deletion appears to work but actually fails silently; the row will re-appear following a refresh.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3310#note-1 Originally created by Dave Page at 2018-04-25 09:41:39 UTC.

Example error from the runtime log:

2018-04-25 09:53:03,099: ERROR pgadmin: Failed to execute query (execute_void) for the server #3 - DB:pgweb(Query-id: 3827405): Error Message:ERROR: update or delete on table "auth_user" violates foreign key constraint "core_userprofile_user_id_fkey" on table "core_userprofile" DETAIL: Key (id)=(1840) is still referenced from table "core_userprofile".

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3310#note-2 Originally created by Akshay Joshi at 2018-04-25 09:42:16 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed		EDB Sprint 13

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3310#note-3 Originally created by Khushboo Vashi at 2018-05-02 10:15:45 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Status changed	New	In Progress
Assigned To changed		Khushboo Vashi

[dpage]

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/2992 Originally created by Khushboo Vashi at 2018-05-02 10:22:52 UTC.

Filename: Screen_Shot_2018-05-02_at_3.51.18_pm.png

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3310#note-5 Originally created by Khushboo Vashi at 2018-05-02 10:23:32 UTC.

Hi Dave,

I have tried to reproduce this issue but it's working fine. Please refer the attached screen-shot for the same. Is there any specific scenario to reproduce this as I have tested with foreign key constraint?

Thanks, Khushboo

Redmine ticket header update:

Name	Old Value	New Value
Attachment added		Screen Shot 2018-05-02 at 3.51.18 pm.png
Status changed	In Progress	New
Assigned To changed	Khushboo Vashi	Dave Page

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3310#note-6 Originally created by Dave Page at 2018-05-03 14:08:50 UTC.

Hmm, no - I can no longer reproduce it either. How odd.

I do see the layout of the alert being messed up as it is in your screenshot though. Can you fix that please? :-)

Redmine ticket header update:

Name	Old Value	New Value
Assigned To changed	Dave Page	Khushboo Vashi

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3310#note-7 Originally created by Khushboo Vashi at 2018-05-07 06:48:15 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Status changed	New	In Progress

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3310#note-8 Originally created by Khushboo Vashi at 2018-05-07 07:25:11 UTC.

Fixed the layout issue of the error message and sent the patch. https://www.postgresql.org/message-id/CAFOhELfABxvRfBoH7BLTFRiFoPg-axf5DB9XaNxmKMp_qJn7PA@mail.gmail.com

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3310#note-9 Originally created by Khushboo Vashi at 2018-05-07 10:35:03 UTC.

Applied in changeset commit:3ac3e73daf8121207fe60eefe6db1aba9c1abcc3.

Redmine ticket header update:

Name	Old Value	New Value
Status changed	In Progress	In Testing
Done Ratio changed	0	90

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3310#note-10 Originally created by Fahar Abbas at 2018-05-08 09:30:10 UTC.

commit 3ac3e73daf8121207fe60eefe6db1aba9c1abcc3

Tested on Windows 2012 R2 64(Python 2.7)

Redmine ticket header update:

Name	Old Value	New Value
Status changed	In Testing	Resolved
Done Ratio changed	90	100

[dpage]

Issue closed on Redmine.