Add support for JIT stats in EXPLAIN output in PG11 (RM #3397) - Githubissues

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.

https://www.pgadmin.org

Other

2.53k stars 656 forks source link

Add support for JIT stats in EXPLAIN output in PG11 (RM #3397) #1878

Closed dpage closed 2 years ago

dpage commented 6 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/3397 Originally created by Dave Page at 2018-06-01 18:46:13 UTC.

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-1 Originally created by Akshay Joshi at 2018-06-08 10:11:59 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed		Ready

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-2 Originally created by Akshay Joshi at 2018-06-20 09:40:53 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	Ready	EDB Sprint 17

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-3 Originally created by Akshay Joshi at 2018-06-26 05:36:50 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Status changed	New	In Progress
Assigned To changed		Akshay Joshi

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-4 Originally created by Akshay Joshi at 2018-06-26 08:47:47 UTC.

Hi Dave,

Following steps I followed to test this:

Run "SET jit_above_cost=10;" query.
Expand Explain options and select "Costs".
Run "SELECT count(*) FROM pg_class; " using Explain and Explain Analyze both.

Got the below output for JIT stats: "JIT": { "Functions": 2, "Optimization": false, "Inlining": false },

EPAS 11 it is not showing JIT stats. What else needs to be check or required some implementation can you please elaborate more.

Redmine ticket header update:

Name	Old Value	New Value
Assigned To changed	Akshay Joshi	Dave Page

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-5 Originally created by Dave Page at 2018-06-26 11:26:51 UTC.

Do the stats who up anywhere on the graphical query plan?

I don't know if anything different is needed in EPAS. It may be that that isn't built with JIT yet.

Redmine ticket header update:

Name	Old Value	New Value
Assigned To changed	Dave Page	Akshay Joshi

dpage commented 6 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/3103 Originally created by Akshay Joshi at 2018-06-27 06:51:33 UTC.

Filename: JIT_Stats.png

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-7 Originally created by Akshay Joshi at 2018-06-27 06:51:44 UTC.

No we are not showing any other statistics except "Plan". For other statistics can we have one button on the right corner of the panel and on hover we will show other stats like "JIT". Please refer attached screenshot.

Is this looks good? If No can you please suggest something.

Redmine ticket header update:

Name	Old Value	New Value
Attachment added		JIT_Stats.png
Assigned To changed	Akshay Joshi	Dave Page

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-8 Originally created by Dave Page at 2018-06-27 08:59:34 UTC.

I like that idea. The button should be visible all the time, regardless of panning or zoom level imho.

Redmine ticket header update:

Name	Old Value	New Value
Assigned To changed	Dave Page	Akshay Joshi

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-9 Originally created by Akshay Joshi at 2018-06-29 08:57:22 UTC.

Patch Sent: https://www.postgresql.org/message-id/CANxoLDdnaPB8gt-v+4aVY2urY8suGqK=pFiWFZ-Agxkgkx_VYw@mail.gmail.com

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-10 Originally created by Akshay Joshi at 2018-07-04 09:36:56 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 17	EDB Sprint 18

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-11 Originally created by Dave Page at 2018-07-06 12:10:32 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Fixed Version changed		3.2

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-12 Originally created by Dave Page at 2018-07-06 12:10:54 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Tracker changed	Bug	Feature

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-13 Originally created by Akshay Joshi at 2018-07-06 12:13:20 UTC.

Applied in changeset commit:2b20b387e2b2ff2cf20e3806248b6ad5ccd22365.

Redmine ticket header update:

Name	Old Value	New Value
Status changed	In Progress	In Testing
Done Ratio changed	0	90

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3397#note-14 Originally created by Fahar Abbas at 2018-07-13 05:09:13 UTC.

commit 0137cfaee377b14607f417dbd929092ae549d958

Windows 2012R2 64(Python 2.7) MAC 10.12(Python 3.6)

Redmine ticket header update:

Name	Old Value	New Value
Status changed	In Testing	Resolved
Done Ratio changed	90	100

dpage commented 2 years ago

Issue closed on Redmine.