Merge latest code of pgcli with pgAdmin4 (RM #3420) - Githubissues

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.

https://www.pgadmin.org

Other

2.43k stars 638 forks source link

Merge latest code of pgcli with pgAdmin4 (RM #3420) #1895

Closed dpage closed 2 years ago

dpage commented 6 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/3420 Originally created by Akshay Joshi at 2018-06-14 07:47:09 UTC.

We have used pgcli's code for SQL Auto completion in Query Tool. We haven't merge the code since last 2 years and they have fixed some bugs and also provided some new features.

Add support for CTE aware auto-completion.
Handle unrecognized keywords gracefully.
Support for table-qualifying column suggestions.
Add additional completion for ALTER keyword.
Better suggestions when editing functions.
Added MATERIALIZED VIEW keywords.
Suggest objects from all schema's (not just those in search_path)
Casing for column headers.
Completions after ORDER BY and DISTINCT now take account of table aliases.
Include arguments in function suggestions.
Add missing keyword COLUMN after DROP

dpage commented 6 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/3078 Originally created by Akshay Joshi at 2018-06-14 07:51:01 UTC.

Filename: Func_with_args.png

dpage commented 6 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/3079 Originally created by Akshay Joshi at 2018-06-14 07:51:01 UTC.

Filename: possible_join.png

dpage commented 6 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/3080 Originally created by Akshay Joshi at 2018-06-14 07:51:18 UTC.

https://pgadmin-archive.postgresql.org/redmine/3420/3080-AutoComplete.patch

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3420#note-4 Originally created by Akshay Joshi at 2018-06-14 07:53:55 UTC.

I have merged the pgcli code with pgAdmin4. It is working fine. Refer attached screenshot of the new features they have added and we merge in pgAdmin4. I have also attached the working patch with some todo's:

TODO:

Will have to write regression tests. pgcli has already wrote test cases in pytest and we are waiting for pgAdmin4 to move on to pytest.
Will have to write feature tests.

Redmine ticket header update:

Name	Old Value	New Value
Attachment added		Func_with_args.png
Attachment added		possible_join.png
Attachment added		AutoComplete.patch
Status changed	New	In Progress
Assigned To changed		Akshay Joshi

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3420#note-5 Originally created by Dave Page at 2018-06-14 08:00:07 UTC.

I wonder if we can modify one of the existing feature tests that writes a query to use auto-complete while it's doing so. I think that would be preferable to a whole new test.

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3420#note-6 Originally created by Khushboo Vashi at 2018-08-03 10:41:17 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed		Ready

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3420#note-7 Originally created by Akshay Joshi at 2018-08-14 12:28:00 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	Ready	EDB Sprint 21

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3420#note-8 Originally created by Akshay Joshi at 2018-08-24 05:38:26 UTC.

Patch sent: https://www.postgresql.org/message-id/CANxoLDfoXcZpYeha5deoiury1UfVNOVBj4=JdoyUfr5AARKMfQ@mail.gmail.com

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3420#note-9 Originally created by Akshay Joshi at 2018-08-27 09:37:04 UTC.

commit id: 7a3f3046df7fa0bdcfab4f0ce7011898ffd75bf6

Redmine ticket header update:

Name	Old Value	New Value
Status changed	In Progress	In Testing

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3420#note-10 Originally created by Dave Page at 2018-09-06 13:05:55 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Fixed Version changed		3.3
Done Ratio changed	0	90

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3420#note-11 Originally created by Fahar Abbas at 2018-11-13 11:52:58 UTC.

This is fixed and tested on windows 64 and OS X on following build: https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2018-11-13/

Redmine ticket header update:

Name	Old Value	New Value
Status changed	In Testing	Resolved
Done Ratio changed	90	100

dpage commented 2 years ago

Issue closed on Redmine.