search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.43k stars 638 forks source link

[PG-11] Drop option is not available for the procedure (RM #3423) #1898

Closed dpage closed 2 years ago

dpage commented 6 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/3423 Originally created by Fahar Abbas at 2018-06-14 08:48:09 UTC.

commit ID:

commit 087db8a75e550d9a7fb61e070cd61f8ee139e9ae

Windows 2012 R2 64(Python 2.7) MAC 10.12(Python 3.6)

  1. install pg-11-beta1
  2. Launch pgadmin4
  3. create procedure

CREATE TABLE test1 (a int);

CREATE PROCEDURE transaction_test1() AS $$ BEGIN FOR i IN 0..9 LOOP INSERT INTO test1 (a) VALUES (i); IF i % 2 = 0 THEN RAISE NOTICE 'i=%, txid=% will be committed', i, txid_current(); COMMIT; ELSE RAISE NOTICE 'i=%, txid=% will be rolledback', i, txid_current(); ROLLBACK; END IF; END LOOP; END $$ LANGUAGE PLPGSQL;

  1. procedure created
  2. Right click newly created procedure
  3. Drop option is not available

Expected Result: Drop option should available for procedure

dpage commented 6 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/3083 Originally created by Fahar Abbas at 2018-06-14 08:48:06 UTC.

Screen_Shot_2018-06-14_at_1.46.43_PM.png

Filename: Screen_Shot_2018-06-14_at_1.46.43_PM.png

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3423#note-2 Originally created by Akshay Joshi at 2018-06-15 10:10:54 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3423#note-3 Originally created by Akshay Joshi at 2018-06-20 09:40:54 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready EDB Sprint 17
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3423#note-4 Originally created by Akshay Joshi at 2018-06-21 07:17:42 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Akshay Joshi
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3423#note-5 Originally created by Akshay Joshi at 2018-06-21 11:11:41 UTC.

Patch Sent: https://www.postgresql.org/message-id/CANxoLDdtUKEUWFbabQR_bAUX6AxbtD5Tusf_1TXfV0OLKTWQJw@mail.gmail.com

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3423#note-6 Originally created by Akshay Joshi at 2018-06-21 20:36:36 UTC.

Applied in changeset commit:560e5f225aca42018a22f69d7d179d8af81f929f.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3423#note-7 Originally created by Dave Page at 2018-06-21 20:36:51 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 3.1
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3423#note-8 Originally created by Fahar Abbas at 2018-06-25 05:40:54 UTC.

This is fixed and tested in 25-June Build on Windows 2016 server 64

https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2018-06-25/

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.