search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.43k stars 638 forks source link

Error when using python 3.7 (RM #3458) #1925

Closed dpage closed 2 years ago

dpage commented 6 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/3458 Originally created by Hans Nieuwenhuis at 2018-07-01 07:29:07 UTC.

When using python 3.7 i get an error when running setup.sh ( see below )

I searched and found : https://github.com/psycopg/psycopg2/issues/714

In pyhton 3.7 aysnc and await are now keywords.

OUTPUT OF setup.sh

Enter the email address and password to use for the initial pgAdmin user account:

Email address: jhmnieuwenhuis@gmail.com Password: Retype password: Traceback (most recent call last): File "setup.py", line 49, in app = create_app() File "/usr/local/lib/python3.7/site-packages/pgadmin4/pgadmin/init.py", line 367, in create_app driver.init_app(app) File "/usr/local/lib/python3.7/site-packages/pgadmin4/pgadmin/utils/driver/init.py", line 40, in init_app DriverRegistry.load_drivers() File "/usr/local/lib/python3.7/site-packages/pgadmin4/pgadmin/utils/driver/registry.py", line 88, in load_drivers module = import_module(module_name) File "/usr/local/lib/python3.7/importlib/init.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "", line 1006, in _gcd_import File "", line 983, in _find_and_load File "", line 967, in _find_and_load_unlocked File "", line 677, in _load_unlocked File "", line 728, in exec_module File "", line 219, in _call_with_frames_removed File "/usr/local/lib/python3.7/site-packages/pgadmin4/pgadmin/utils/driver/psycopg2/init.py", line 26, in from .connection import Connection File "/usr/local/lib/python3.7/site-packages/pgadmin4/pgadmin/utils/driver/psycopg2/connection.py", line 148 def init(self, manager, conn_id, db, auto_reconnect=True, async=0, ^ SyntaxError: invalid syntax

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-1 Originally created by Hans Nieuwenhuis at 2018-07-01 07:30:06 UTC.

In pyhton 3.7 async and await are now keywords.

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-2 Originally created by Akshay Joshi at 2018-07-06 10:44:35 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-3 Originally created by Dave Page at 2018-07-20 10:43:17 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready EDB Sprint 20
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-4 Originally created by Akshay Joshi at 2018-08-01 09:54:32 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Akshay Joshi
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-5 Originally created by Akshay Joshi at 2018-08-02 08:35:58 UTC.

Patch sent: https://www.postgresql.org/message-id/CANxoLDcoqxeV=njKW1mwJqYt0F=x1vDrvNBnaCdC4hhyaifQvA@mail.gmail.com

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-6 Originally created by Hans Nieuwenhuis at 2018-08-02 18:30:36 UTC.

Hi, I tested the patch and I can confirm that it works fine now.

Excellent Job !!

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-7 Originally created by Akshay Joshi at 2018-08-06 10:05:14 UTC.

Applied in changeset commit:52fc0846cdd16dd3c780c5d4277d3f71055506e8.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-8 Originally created by Fahar Abbas at 2018-08-08 05:35:41 UTC.

Resolved.

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
Done Ratio changed 90 100
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-9 Originally created by Fahar Abbas at 2018-08-08 06:58:53 UTC.

Verification is in progress with latest python 3.7 i resolved it after comments of User.

Redmine ticket header update:

Name Old Value New Value
Status changed Resolved In Testing
Done Ratio changed 100 90
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-10 Originally created by eduardo23garcia . at 2018-08-16 17:03:27 UTC.

Fahar Abbas wrote:

Verification is in progress with latest python 3.7 i resolved it after comments of User. Some new about when this fix will be up?

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-11 Originally created by Khushboo Vashi at 2018-08-17 04:48:07 UTC.

This is already available in the latest pgAdmin 4 v3.2 release.

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3458#note-12 Originally created by Fahar Abbas at 2018-09-05 14:50:38 UTC.

I have already done a pgAdmin4 setup on Ubuntu 18.04 Linux 64 and MAC OS X 10.13 on pgAdmin4 3.3 and there is no error message display when user do a python3.7 for pgadmin4 with setup and pgAdmin4.py.

I have also done a smoke verification on Ubuntu 18.04 64.

One issue raised with yarn community for MAC 10.13: https://github.com/yarnpkg/yarn/issues/6360

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.