search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.53k stars 656 forks source link

Detele/drop and drop cascade option under properties section should be disabled for pg_catalog (RM #3797) #2187

Closed dpage closed 2 years ago

dpage commented 5 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/3797 Originally created by Fahar Abbas at 2018-12-04 13:27:57 UTC.

Tested Platform: MAC 10.14

Build:

https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2018-12-04/

If try to drop any object through properties tab for pg_catalog it's allowed. I think, Delete/Drop option should be disabled for pg_catalogs.

Steps:

  1. open pgAdmin4
  2. Go into postgresql catalog section
  3. click on main table or type node
  4. Click on properties
  5. Check the delete and drop options

It should be disabled

dpage commented 5 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/3453 Originally created by Fahar Abbas at 2018-12-04 13:21:55 UTC.

pg_catalog_drop_button_1.png

Filename: pg_catalog_drop_button_1.png

dpage commented 5 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/3454 Originally created by Fahar Abbas at 2018-12-04 13:22:07 UTC.

pg_catalog_button_2.png

Filename: pg_catalog_button_2.png

dpage commented 5 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/3455 Originally created by Fahar Abbas at 2018-12-04 13:22:21 UTC.

pg_catalog_button_3.png

Filename: pg_catalog_button_3.png

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3797#note-4 Originally created by Akshay Joshi at 2018-12-05 10:44:09 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 29
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3797#note-5 Originally created by Khushboo Vashi at 2018-12-07 08:42:47 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Khushboo Vashi
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3797#note-6 Originally created by Khushboo Vashi at 2018-12-12 09:05:20 UTC.

The patch sent. https://www.postgresql.org/message-id/CAFOhELdSQNOHuerOEP-3YhCVC88GTDSW9MK4X1mH3tOa73bpEw@mail.gmail.com

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3797#note-7 Originally created by Dave Page at 2018-12-13 10:58:34 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 4.0
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3797#note-8 Originally created by Khushboo Vashi at 2018-12-13 11:03:35 UTC.

Applied in changeset commit:dfbb2212c0e12892991742061f4b98f89fb009bd.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3797#note-9 Originally created by Fahar Abbas at 2018-12-17 06:05:28 UTC.

This is resolved is Windows 64 and MAC OS X

Tested Build:

https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2018-12-17/

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.