pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.43k stars 638 forks source link

Table node: Generated SQL statements aren't separated. (RM #1234) #230

Closed dpage closed 2 years ago

dpage commented 8 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/1234 Originally created by Thom Brown at 2016-05-25 15:16:30 UTC.

When configuring a table on the Create Table dialog, there should be a blank line between statements as it looks like one big statement.

For example, the following is generated from trying to create a new table in the dialog:


CREATE TABLE public.test
(
    a bigint,
    PRIMARY KEY (a)
)
WITH (
    OIDS = FALSE
)
TABLESPACE pg_default;
ALTER TABLE public.test
    OWNER to thom;
COMMENT ON TABLE public.test
    IS 'This is a test';
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1234#note-1 Originally created by Murtuza Zabuawala at 2016-06-01 07:44:11 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Murtuza Zabuawala
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1234#note-2 Originally created by Murtuza Zabuawala at 2016-06-01 07:55:04 UTC.

PATCH sent,

https://www.postgresql.org/message-id/CAKKotZSk=TO2Lv+iirX+_jLZ6qNK_MCw_DG4d2rAEVieEj6Urg@mail.gmail.com

dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1234#note-3 Originally created by Murtuza Zabuawala at 2016-06-03 10:18:31 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress New
Assigned To changed Murtuza Zabuawala
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1234#note-4 Originally created by Murtuza Zabuawala at 2016-06-23 05:38:01 UTC.

patch sent,

https://www.postgresql.org/message-id/CAKKotZSmZWHZwwZbakCkXbUWB%3DXurG_d%3Dz-zO2Lj2zHrCW5smg%40mail.gmail.com

dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1234#note-5 Originally created by Murtuza Zabuawala at 2016-06-23 05:38:27 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Murtuza Zabuawala
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1234#note-6 Originally created by Dave Page at 2016-06-23 11:36:20 UTC.

Applied in changeset commit:4983eb2f1cd0b87e9309477bab0be0ec6e2c7893.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 8 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/1408 Originally created by Vishal Sawale at 2016-07-01 11:19:14 UTC.

https://pgadmin-archive.postgresql.org/redmine/1234/1408-Screen_Shot_2016-07-01_at_3.38.12_pm.png

dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1234#note-8 Originally created by Vishal Sawale at 2016-07-01 11:19:29 UTC.

This has been verified on windows as well as linux and now there is significance space between SQL's. Hence marking it as resolved.

git commit - c45960df5e5a004f682eed16da02c0d41887a670

Redmine ticket header update:

Name Old Value New Value
Attachment added Screen Shot 2016-07-01 at 3.38.12 pm.png
Status changed In Testing Resolved
dpage commented 2 years ago

Issue closed on Redmine.