pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.43k stars 638 forks source link

Edit data tables with primary key spanning multiple columns [Partition table] (RM #4104) #2462

Closed dpage closed 2 years ago

dpage commented 5 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/4104 Originally created by Franco Ricci at 2019-03-23 10:25:12 UTC.

In pgAdmin 4.2 and 4.3 is not possible edit data in tables with a primary key spanning multiple columns.

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4104#note-1 Originally created by Dave Page at 2019-03-24 02:13:53 UTC.

It works for me in GIT HEAD, and I cannot see any changes that might have affected that behaviour since 4.3. Can you provide a reproducible test case please?

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Franco Ricci
dpage commented 5 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/3711 Originally created by Franco Ricci at 2019-03-24 16:23:59 UTC.

https://pgadmin-archive.postgresql.org/redmine/4104/3711-exempale.sql

Description: Partitined table

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4104#note-3 Originally created by Franco Ricci at 2019-03-24 16:26:45 UTC.

You are right. The problem is not the primary key but partitioned table. In attached example.sql in the root partitioned table is not possible either add record either edit the exists ones. The same NOT partioned table works well in pgAdmin. I'm using Postgresql 11.2

It's a bug??

Redmine ticket header update:

Name Old Value New Value
Attachment added exempale.sql
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4104#note-4 Originally created by Aditya Toshniwal at 2019-03-29 10:46:16 UTC.

Redmine ticket header update:

Name Old Value New Value
Subject changed Edit data tables with primary key spanning multiple columns Edit data tables with primary key spanning multiple columns [Partition table]
Assigned To changed Franco Ricci
Sprint changed Ready
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4104#note-5 Originally created by Khushboo Vashi at 2019-04-03 07:43:54 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Khushboo Vashi
Sprint changed Ready EDB Sprint 37
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4104#note-6 Originally created by Khushboo Vashi at 2019-04-03 10:45:59 UTC.

Patch sent. https://www.postgresql.org/message-id/CAFOhELe-Eks+mvaE8x1ezdqGiVSBGAvYbBnDr7MRTAQgFbOemw@mail.gmail.com

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4104#note-7 Originally created by Franco Ricci at 2019-04-08 07:40:52 UTC.

I tested the patch against pgAdmin 4.4. It works well and now I can edit partitioned table.

Thanks

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4104#note-8 Originally created by Akshay Joshi at 2019-04-09 06:32:15 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 4.6
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4104#note-9 Originally created by Akshay Joshi at 2019-04-10 09:32:52 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 37 EDB Sprint 38
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4104#note-10 Originally created by Khushboo Vashi at 2019-04-11 07:57:50 UTC.

Applied in changeset commit:a9d964b5ca04bbe00bf5585d5c19bdfdf603c8a9.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4104#note-11 Originally created by Fahar Abbas at 2019-04-22 07:02:11 UTC.

This is Resolved in latest Build: https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2019-04-22/

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.