pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.43k stars 637 forks source link

version 4.8: tables properties dialog isn't re-sizable, and the horizontal scroll bar doesn't work on Kubuntu/chromium (RM #4374) #2683

Closed dpage closed 2 years ago

dpage commented 5 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/4374 Originally created by richard coleman at 2019-06-19 12:35:55 UTC.

Running:

Kubuntu 18.04 Chromium Version 75.0.3770.90 (Official Build) Built on Ubuntu , running on Ubuntu 18.04 (64-bit) pgAdmin4:

Version 4.8 Python Version 3.6.8 (default, Jan 14 2019, 11:02:34) [GCC 8.0.1 20180414 (experimental) [trunk revision 259383]] Flask Version 0.12.2 Application Mode Desktop Current User pgadmin4@pgadmin.org

The tables properties window is not re-sizable and the horizontal scroll bar is disabled(the vertical scroll bar still works). This means that I can't see all of the columns. The pointer icon changes to indicate that it's re-sizable, but it doesn't actually do anything. The was not a problem in previous versions.

The developer tools console shows the following errors when the table properties form is displayed:

Unchecked runtime.lastError: Could not establish connection. Receiving end does not exist. vendor.js:93 exported wcDocker vendor.js:155 sprintf() will be removed in the next major release, use the sprintf-js package instead. n @ vendor.js:155 :37049/static/js/generated/app.bundle.js?ver=40800:18 Uncaught TypeError: Cannot read property 'chart_obj' of undefined at Object. (:37049/static/js/generated/app.bundle.js?ver=40800:18) at l (vendor.js:39) at Object.fireWith [as resolveWith] (vendor.js:39) at u (vendor.js:39) at XMLHttpRequest. (vendor.js:39) vendor.js?ver=40800:39 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

dpage commented 5 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/3983 Originally created by richard coleman at 2019-06-19 12:29:34 UTC.

pgAdmin4_4.8_table_properties.png

Filename: pgAdmin4_4.8_table_properties.png

Description: table properties form

dpage commented 5 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/3984 Originally created by richard coleman at 2019-06-19 12:32:59 UTC.

pgAdmin4_4.8_table_properties_form_errors.png

Filename: pgAdmin4_4.8_table_properties_form_errors.png

Description: errors when displaying table properties form

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4374#note-3 Originally created by Aditya Toshniwal at 2019-06-19 14:53:06 UTC.

Hi Richard,

The errors that you're getting in console (you can ignore the chart_obj one) are not related to the dialog resizing. I tried on chrome and I'm able to scroll. (Very less possibility) Can you check what is checked under File -> Lock Layout ? If it is Full then select None. Unfortunately, we are not able to reproduce.

Thanks.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed richard coleman
dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4374#note-4 Originally created by richard coleman at 2019-06-19 15:18:02 UTC.

Aditya,

It's set to "Full Lock".

Apparently that's how it came, I didn't know that setting existed.

Setting it to "None" apparently allows me to resize that form, and now the horizontal scroll bar is working.

It seems the real bug might be the non-functional h-scroll bar when set to "Full Lock" or "Prevent Docking".

rik.

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4374#note-5 Originally created by Aditya Toshniwal at 2019-06-19 15:23:29 UTC.

Hi Richard,

The default is None. You can check the commit - https://github.com/postgres/pgadmin4/commit/2dd075161d811c0db1e502d1dbc92627a2bec0f1 (web/pgadmin/browser/register_browser_preferences.py) Also, I'm able to scroll in all modes of Lock layout.

Thanks.

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4374#note-6 Originally created by richard coleman at 2019-06-19 15:31:25 UTC.

Aditya,

I am glad to hear that you are not having difficulties with the horizontal scroll bar. Are you using Chromium on Linux (see above)? I can confirm that with the "Lock Layout" set to anything other than "None" the horizontal scroll bar is non-functional.

rik.

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4374#note-7 Originally created by Aditya Toshniwal at 2019-06-19 15:58:38 UTC.

Hi Richard,

It is unfortunate that you were not aware of Lock layout setting. We had mentioned this in pgAdmin release mail. Plus it is there in the release note and docs.

We will surely try to simulate this.

Thanks.

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4374#note-8 Originally created by Khushboo Vashi at 2019-06-21 10:10:48 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed richard coleman
Sprint changed Ready
dpage commented 3 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4374#note-9 Originally created by Akshay Joshi at 2021-02-26 11:54:27 UTC.

Hi Richard

Can you please verify it on the latest pgAdmin4 v5.0?

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready
Assigned To changed richard coleman
dpage commented 3 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4374#note-10 Originally created by richard coleman at 2021-02-26 14:37:04 UTC.

Running pgAdmin 4 v 5.0 on Kubuntu 20.10, you can now move the horizontal bar regardless of the lock settings. The placement is a bit off, you have to position your mouse just above the scroll bar, but then it seems to work. Thanks for the work.

dpage commented 3 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4374#note-11 Originally created by Akshay Joshi at 2021-03-02 06:30:02 UTC.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 0 100
Status changed New Resolved
dpage commented 2 years ago

Issue closed on Redmine.