search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.53k stars 656 forks source link

keyboard shortcut Ctrl + / does not work for commenting selected lines (RM #4593) #2870

Closed dpage closed 2 years ago

dpage commented 5 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/4593 Originally created by Nico Kne at 2019-08-09 11:26:43 UTC.

i use windows 10 last version, chrome last version and pgadmin last version

dpage commented 5 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4593#note-1 Originally created by Khushboo Vashi at 2019-08-30 10:50:38 UTC.

Fahar,

Can you please test it?

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Fahar Abbas
dpage commented 4 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4593#note-2 Originally created by Fahar Abbas at 2019-11-18 06:24:32 UTC.

Hi Nico,

Can you please share the steps to reproduce?

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Fahar Abbas Nico Kne
dpage commented 4 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4593#note-3 Originally created by Nico Kne at 2019-11-19 12:36:18 UTC.

sure

windows 10 64bit 1809 version (compilation 17763.864) pgadmin v4.15

1- open pgadmin4 2- select one database 3- right click and select "Query Tool" 4- write anything 5- press Ctrl + / nothing happens, no commented line

dpage commented 4 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4593#note-4 Originally created by Akshay Joshi at 2019-12-06 11:11:07 UTC.

Hi Nico

Can you please share the statement/line where you tried Ctrl + /.

dpage commented 4 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4593#note-5 Originally created by Nico Kne at 2019-12-06 11:44:19 UTC.

no matter what i write or in wich line, Ctrl + / does not generate a comment in the current line nor in the selected lines

dpage commented 4 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/4423 Originally created by Akshay Joshi at 2019-12-06 12:41:05 UTC.

Comment_Issue.png

Filename: Comment_Issue.png

dpage commented 4 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4593#note-7 Originally created by Akshay Joshi at 2019-12-06 12:41:07 UTC.

Hi Nico

We are asking this because when we have multi-line text inside quotes then comment using CTRL + / not working for us as well. For other scenarios, it is working. Please refer to the attached screenshot.

Redmine ticket header update:

Name Old Value New Value
Attachment added Comment_Issue.png
dpage commented 4 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/4593#note-8 Originally created by Aditya Toshniwal at 2020-01-03 11:57:55 UTC.

No response from the author. Closing the issue.

Redmine ticket header update:

Name Old Value New Value
Status changed New Rejected
dpage commented 2 years ago

Issue closed on Redmine.