pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.27k stars 611 forks source link

Error in template sql/12_plus/create.sql (RM #5917) #3890

Closed dpage closed 1 year ago

dpage commented 3 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/5917 Originally created by Didier PORTEFAIX at 2020-10-15 09:32:07 UTC.

Versions:

OS: CentOS Linux release 7.8.2003 (Core)

When trying to create a new table, on a newly created postgresql cluster, a HTTP 500 error is encountered It seems the databases/schemas/tables/templates/tables/sql/12_plus/create.sql file raise an error with the template "{% set ns.add_comma = true%}"

I had to replace all occurrences to "{% set ns = namespace(add_comma=true) %}" to have it work

Stack trace [Wed Oct 14 13:00:13.977907 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py", line 1265, in get_sql [Wed Oct 14 13:00:13.977911 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] data=data, conn=self.conn) [Wed Oct 14 13:00:13.977915 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/flask/templating.py", line 134, in render_template [Wed Oct 14 13:00:13.977919 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] return _render(ctx.app.jinja_env.get_or_select_template(template_name_or_list), [Wed Oct 14 13:00:13.977923 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/jinja2/environment.py", line 851, in get_or_select_template [Wed Oct 14 13:00:13.977927 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] return self.get_template(template_name_or_list, parent, globals) [Wed Oct 14 13:00:13.977931 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/jinja2/environment.py", line 812, in get_template [Wed Oct 14 13:00:13.977935 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] return self._load_template(name, self.make_globals(globals)) [Wed Oct 14 13:00:13.977939 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/jinja2/environment.py", line 786, in _load_template [Wed Oct 14 13:00:13.977948 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] template = self.loader.load(self, name, globals) [Wed Oct 14 13:00:13.977952 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/jinja2/loaders.py", line 125, in load [Wed Oct 14 13:00:13.977955 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] code = environment.compile(source, name, filename) [Wed Oct 14 13:00:13.977959 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/jinja2/environment.py", line 565, in compile [Wed Oct 14 13:00:13.977991 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] self.handle_exception(exc_info, source_hint=source_hint) [Wed Oct 14 13:00:13.977996 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/jinja2/environment.py", line 754, in handle_exception [Wed Oct 14 13:00:13.978000 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] reraise(exc_type, exc_value, tb) [Wed Oct 14 13:00:13.978004 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/jinja2/_compat.py", line 37, in reraise [Wed Oct 14 13:00:13.978014 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] raise value.with_traceback(tb) [Wed Oct 14 13:00:13.978018 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/tables/sql/12_plus/create.sql", line 88, in template [Wed Oct 14 13:00:13.978023 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] {% if data.fillfactor %}{% set ns.add_comma = true%} [Wed Oct 14 13:00:13.978028 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/jinja2/environment.py", line 470, in _parse [Wed Oct 14 13:00:13.978032 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] return Parser(self, source, name, encode_filename(filename)).parse() [Wed Oct 14 13:00:13.978036 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/jinja2/parser.py", line 897, in parse [Wed Oct 14 13:00:13.978039 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] result = nodes.Template(self.subparse(), lineno=1) [Wed Oct 14 13:00:13.978043 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] File "/usr/lib/python3.6/site-packages/pgadmin4-web/jinja2/parser.py", line 879, in subparse [Wed Oct 14 13:00:13.978047 2020] [wsgi:error] [pid 2380] [remote 95.143.79.106:60668] rv = self.parse_statement()

dpage commented 3 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/5917#note-1 Originally created by Aditya Toshniwal at 2020-10-15 09:46:16 UTC.

Hi Didier,

Please refer - #5903 for the solution. This issue is same as #5903.

Thanks.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Didier PORTEFAIX
Status changed New Resolved
dpage commented 3 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/5917#note-2 Originally created by Aditya Toshniwal at 2020-10-15 09:46:45 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed Resolved Rejected
dpage commented 1 year ago

Issue closed on Redmine.