[React] Port query tool to React (RM #6131)

[dpage]

Issue migrated from Redmine: https://redmine.postgresql.org/issues/6131 Originally created by Akshay Joshi at 2021-01-07 08:12:24 UTC.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-1 Originally created by Akshay Joshi at 2021-01-07 08:12:36 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 82	Ready

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-2 Originally created by Akshay Joshi at 2021-02-26 11:33:43 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #3827

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-3 Originally created by Akshay Joshi at 2021-06-04 11:59:12 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Tracker changed	Feature	Housekeeping

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-4 Originally created by Akshay Joshi at 2021-10-13 10:28:13 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	Ready	EDB Sprint 102
Assigned To changed		Aditya Toshniwal

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-5 Originally created by Akshay Joshi at 2021-10-27 04:48:32 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Status changed	New	In Progress

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-6 Originally created by Akshay Joshi at 2021-10-27 10:30:32 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 102	EDB Sprint 103

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-7 Originally created by Akshay Joshi at 2021-11-10 10:31:35 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 103	EDB Sprint 104

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-8 Originally created by Akshay Joshi at 2021-11-24 10:35:21 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 104	EDB Sprint 105

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-9 Originally created by Aditya Toshniwal at 2021-11-30 08:55:13 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #3989

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-10 Originally created by Aditya Toshniwal at 2021-11-30 08:55:49 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #3253

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-11 Originally created by Aditya Toshniwal at 2021-11-30 08:57:04 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #6830

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-12 Originally created by Akshay Joshi at 2021-12-08 10:34:38 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 105	EDB Sprint 106

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-13 Originally created by Akshay Joshi at 2021-12-22 10:34:33 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 106	EDB Sprint 107

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-14 Originally created by Aditya Toshniwal at 2021-12-27 08:35:17 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #4113

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-15 Originally created by Akshay Joshi at 2022-01-05 11:12:15 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 107	EDB Sprint 108

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-16 Originally created by Akshay Joshi at 2022-01-19 10:32:05 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 108	EDB Sprint 109

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-17 Originally created by Aditya Toshniwal at 2022-01-27 05:32:43 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #6969

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-18 Originally created by Akshay Joshi at 2022-02-02 10:31:22 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 109	EDB Sprint 110

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-19 Originally created by Akshay Joshi at 2022-02-16 10:32:14 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 110	EDB Sprint 111

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-20 Originally created by Aditya Toshniwal at 2022-03-02 08:59:43 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #7188

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-21 Originally created by Aditya Toshniwal at 2022-03-02 09:25:07 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #6725

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-22 Originally created by Akshay Joshi at 2022-03-02 10:38:27 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 111	EDB Sprint 112

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-23 Originally created by Akshay Joshi at 2022-03-16 10:30:51 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 112	EDB Sprint 113

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-24 Originally created by Aditya Toshniwal at 2022-03-23 06:01:07 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #7262

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-25 Originally created by Akshay Joshi at 2022-03-25 09:03:08 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #7260

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-26 Originally created by Akshay Joshi at 2022-03-30 10:32:07 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 113	EDB Sprint 114

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-27 Originally created by Aditya Toshniwal at 2022-04-07 04:50:49 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #7294

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-28 Originally created by Aditya Toshniwal at 2022-04-07 12:07:58 UTC.

Applied in changeset commit:b5b9ee46a1f7aa9cc228e6c4c676da20c80a8260.

Redmine ticket header update:

Name	Old Value	New Value
Done Ratio changed	0	90
Status changed	In Progress	In Testing

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-29 Originally created by Akshay Joshi at 2022-04-07 12:10:15 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Fixed Version changed		6.9
Assigned To changed	Aditya Toshniwal	Yogesh Mahajan

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-30 Originally created by Yogesh Mahajan at 2022-04-11 09:14:44 UTC.

Issues reported while testing - 1.Add New Server Connection > Server options keep loading(For empty Server group) 2.Not able to load more than 1000 rows 3.Find/Replace both opens same dialogue box. 4.After clicking indent/Un-indent(for al operations) for large query option left as it is till operation completes. 5.Small white line is added below Total rows status bar. 6.Also check sign beside options in Execute Option/Copy Header is little bit big 7.Clicking arrows after opening dropdown options, does not collapse dropdown. 8.In explain > Analysis tab does not show ROWS column.(film table) 9.In explain > Data output > Query Plan is editable. 10.In explain > Explain > analysis previous explain output is NOT cleared. New rows are appended. Same applies to statics tab. 11.Update new query tool connection tool tip.(7289) 12.Explain-Analyze > Loops column is empty.(pg_class) 13.Explain-Analyze with Verbose & Costs > in ROW X columns upward arrows are missing.(pg_class) 14.Explain-Analyze with all option checked > background colors are missing for timing. 15.Explain-Analyze > Additional bullet is added before Hash Cond 16.Explain-Analyze with all option checked > Statistics tab > % of query is always 0 for node type 17.Browser Tree > Filtered rows icon is not working. 18.Color is NOT fainted in View/Edit data when query tool is NOT editable. 19.Edit any table with PK > Try to insert duplicate PK > Error thrown > Correct pK value > Still old error shown > Not able to add new entry (This works when focus is moved from edited cell) 20.Create table with time stamp and default value as function now() > Add new row > Enter mandatory columns except column where default value is function(now()) > Click Save > New row added but column with default value has value [default]. not updated to actual value. / Default values are not considered for any column while adding new entry. 21.Disable execute options in View/Edit data. 22.In Result grid multiple rows can not be selected with shift + down arrow 23.Boolean column always shows null 24.In Query history Remove & Remove all buttons are sticked to each other. 2:00 25.On Remove all, other panel is empty.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-31 Originally created by Yogesh Mahajan at 2022-04-13 08:34:04 UTC.

New issue - 1.If data in result grid is edited & changes are reverted, then also Save button remain enabled/ Cell is shown in bold indicating data is edited. 2.Create a column with boolean[]/ text[], Try to add new entry from data grid, enter “” quotes > Click Ok > Now try edit cell > You can not change value. 3..Try to edit cell with char varying data type(which opens text editor) > Scroll result grid > Click on another cell > query edior shows white screen & refresh is the only option left.(TypeError: Cannot read properties of null (reading 'querySelector') at getCellElement (sqleditor.js?ver=60800:1:995456)) 4.Generate scrip is not working for schema diff for tables with target only/ not working for any.(TypeError: Cannot read properties of undefined (reading 'database')) 5.In Geometry Viewer , map disappears if taken to bottom. 6.Query results are appended in Notification tab. 7.When the Save button is disabled then 'Save as' should be disabled as well. 8.Panel name is NOT updated on opening file. Panel-name should be filename 9.Open a file in query tool > Open another file > Check panel name > It is first file name 10.Manage Macros - Help button is disabled. Remove SQL help button(Not sure) 11.Macros defined in one database are shown for other databases also/even across servers 12.Keyboard short cut - Focus in query tool and try Previous/Next tab is Not working add quotes in query tool 13.Keyboard shortcut Switch Panel is not working 14.Incorrect CSV downlaoded (film table) when CSV quotes select single quote from preferences. 15.Query tool notifier setting is missing in preferences. 16.In quert history - Select queries are suffixed by ’Save Data’ icon 17.In Data grid > Add New data to cell > without clicking on other cell click on Add New row > previous data is gone.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-32 Originally created by Akshay Joshi at 2022-04-13 10:31:10 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 114	EDB Sprint 115

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-33 Originally created by Libor M. at 2022-04-17 12:35:21 UTC.

This issue implementation introduce a lot of texts which are not translatable. It needs to be checked and add gettext function. The worst part is that it happens at most ports to React :-/

[dpage]

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/6745 Originally created by Fahar Abbas at 2022-04-19 07:17:07 UTC.

Filename: Screen_Shot_2022-04-19_at_12.15.12_PM.png

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-35 Originally created by Fahar Abbas at 2022-04-19 07:17:40 UTC.

Snapshot build: https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2022-04-19/

I have found one issue if click on query history

Steps:

1. Click on the table
2. Click on view data
3. Click on query history
4. Open query tool
5. Fail to fetch the query message displayed.

Redmine ticket header update:

Name	Old Value	New Value
Attachment added		Screen Shot 2022-04-19 at 12.15.12 PM.png

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-36 Originally created by Yogesh Mahajan at 2022-04-19 11:14:03 UTC.

Hi,

Here some issues which are still reproducible - 1.Find/Replace both opens the same dialogue box.(by clicking menu option) 2.Try to edit cell with char varying data type(which opens text editor, leave editor open) > Scroll result grid verticall so that ediot disappaears > Click on another cell > query edior shows white screen & refresh is the only option left.(TypeError: Cannot read properties of null (reading 'querySelector’) - Issue is not reproducible if you scroll horizontally. 3.1.Add New Server Connection > Server options keep loading(For multiple Server groups & should have some server)

New issues - 1.C should be captial in ’<New connection…>' 2.In pop title for New Connection, all words should be capital.(Add new connection) 3.In New connection > Select server which is not connected > New popup asking for password shown > This pop is not identical to pop up shown on double clciking server for connection. 4.In Add new connection password is not asked when some other is tries to connect. For e.g. currently postgres db is connected with postgres user. Now with Add new connection select postgres db & user as foo1 > A pop should be shown for asking password. 5.Rows are not loading after 10000. Specific to Firefox 6.Explain > Analaysis tab > Column heading missing ROWS PLAN(select * from pg_class) with cost & In explain only. 7.Explain > Analaysis tab > with cost enabled > Upward arrow size does not match with font of number. Arrow is little bigger than number. 8.Boolean default is not considered while ading new row.(try table from feature test defaults) 9.In query history , when not query history present, warning icon size big. Match it to warning message - No history found 10.Any cell just open by clicking it > Do NOT change any thing > Click Ok > Cell is shown as edited. 11.Select table/db object > Open query tool from Tools menu > NOT FOUND error is shown.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-37 Originally created by Nikhil Mohite at 2022-04-22 08:02:31 UTC.

Few observations in the Query Tool:

Query panel in the query tool should have some min-width, if we resize the Scratchpad it completely hides the Query panel and it is difficult to resize it again.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-38 Originally created by Yogesh Mahajan at 2022-04-25 05:46:28 UTC.

New Issues - 1.In Find dialogue > No way to know if no match found. 2.Replace functionality does not work when tried in sequence 2 time. 3.Replace all does not work when tried in sequence 2 time. 4.Create New DB > Open Query tool > Switch to Query History > Clear History > Create new function in same DB > Open QT by selecting that function > Failed to fetch query history error might be there. 5.In copy paste row, if copied rown has [null], then that are pasted as empty string. 6.When query does not return any data outptut > Data output panel still shows msg No data output please execute a query. When Dataoutput is empty show empty grid.(With table having no columns) 7.Detach the DataOutput panel > Try editing text cell > Text editor is hidden behind data output panel. (Same for Json editor)

Desktop Mode 1.In preferences > tab setting > set query tool to open in tab. > Open View/edit data for any table > New tab opend has title Untitled.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-39 Originally created by Yogesh Mahajan at 2022-04-25 13:33:37 UTC.

1.Add min width to whole pgAdmin so that, query tool bar options are not hidden, currently min width of pgadmin is equal to width of connection status dropdown. 2.In Dark mode > Replace/Find dialogue forward & reverse button are sticked to each other. 3.In Dark/High contrast mode > Checkbox is not visble for false value 4.In Dark/High contrast mode > Arrow is NOT visible for No limit dd.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-40 Originally created by Akshay Joshi at 2022-04-27 10:02:37 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed	EDB Sprint 115	EDB Sprint 116

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-41 Originally created by Fahar Abbas at 2022-04-28 12:03:47 UTC.

In the case of 0 rows, an Internal server error is displayed if the user clicks on Save result to file under the Data output tab for query tool Window.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-42 Originally created by Yogesh Mahajan at 2022-04-29 05:42:23 UTC.

New issue s> 1.Select some cell > try Filter by Selection > Remove sort/filter > Try Exclude by Selection > Nothing happens 2.In view/edit data > Click on filter icon to open filter dialogue > Enter SQL filter > Click Save > Error shown. 3.Copy button is disabled on selecting some cell. It should be enabled as selecting cell & cmd+c, copies cell data in clipboard.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-43 Originally created by Yogesh Mahajan at 2022-04-29 07:08:48 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #7334

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6131#note-44 Originally created by Yogesh Mahajan at 2022-05-11 08:22:25 UTC.

Detailed testing had been done on new query tool & also verified issues reported above. Testing had been done in Desktop & Server mode & also on linux, windows & Mac platform. For server mode testing had been done mostly on Chrome - 101.x, FF-100.x & Safari 15.4.

For library related issues new RM 7334 is created.

Redmine ticket header update:

Name	Old Value	New Value
Status changed	In Testing	Resolved

[dpage]

Issue closed on Redmine.