search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.53k stars 656 forks source link

Unable to drop trigger function, function and procedures (RM #1467) #435

Closed dpage closed 2 years ago

dpage commented 8 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/1467 Originally created by Fahar Abbas at 2016-07-18 11:58:09 UTC.

commit ID:

c45960df5e5a004f682eed16da02c0d41887a670

Tested Platform: Ubuntu Linux 32/Linux 64

Python Version: 3.4 and 3.5

Browser version

Firfox 46.0.1

Unable to drop trigger function and in SQL pane following message displayed:

-- FUNCTION: name

-- DROP FUNCTION name;

func_def

Please note that it's a new regression.

Steps:

  1. Launch pgAdmin4
  2. Connect to edb postgres Advanced Server or Pg-9.6
  3. Expand database edb
  4. Launch Query tool window

  5. create following trigger function

    CREATE FUNCTION public.test_new_1() RETURNS trigger LANGUAGE 'plpgsql' NOT LEAKPROOF AS $BODY$ begin null; end; $BODY$;

  6. trigger function created
  7. Check the SQL Pane
  8. try to drop particular trigger function
dpage commented 8 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/1453 Originally created by Fahar Abbas at 2016-07-18 11:51:55 UTC.

https://pgadmin-archive.postgresql.org/redmine/1467/1453-Screen_Shot_2016-07-18_at_4.51.18_pm.png

dpage commented 8 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/1454 Originally created by Fahar Abbas at 2016-07-18 11:51:57 UTC.

https://pgadmin-archive.postgresql.org/redmine/1467/1454-Screen_Shot_2016-07-18_at_4.51.44_pm.png

dpage commented 8 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/1463 Originally created by Fahar Abbas at 2016-07-19 11:57:33 UTC.

https://pgadmin-archive.postgresql.org/redmine/1467/1463-Screen_Shot_2016-07-19_at_4.54.08_AM.png

dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1467#note-4 Originally created by Fahar Abbas at 2016-07-19 11:57:53 UTC.

Issue is also reproducible in PostgreSQL-9.6-beta3 OS X installer with Desktop application:

Python version 2.7.11

Installer version:

Pick beta3 installers from daily build.

PostgreSQL 9.6 --- Built on 2016-07-19 07:48:45 IB: 15.10.1-201511121057

Redmine ticket header update:

Name Old Value New Value
Attachment added Screen Shot 2016-07-19 at 4.54.08 AM.png
Subject changed Unable to drop trigger function Unable to drop trigger function and function
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1467#note-5 Originally created by Dave Page at 2016-07-21 09:45:50 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 1.0 Beta 4
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1467#note-6 Originally created by Fahar Abbas at 2016-08-03 12:06:35 UTC.

User can not drop procedure as well.

Redmine ticket header update:

Name Old Value New Value
Subject changed Unable to drop trigger function and function Unable to drop trigger function, function and procedures
Platform changed All
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1467#note-7 Originally created by Khushboo Vashi at 2016-08-04 11:17:54 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Khushboo Vashi
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1467#note-8 Originally created by Khushboo Vashi at 2016-08-04 11:22:37 UTC.

Fixed this issue and sent the patch.

Ref: https://www.postgresql.org/message-id/CAFOhELdhbzfBS=NyWJYvWCmycOR4aEP4sv5HA2Dcnxr__3qvVA@mail.gmail.com

dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1467#note-9 Originally created by Khushboo Vashi at 2016-08-04 14:24:07 UTC.

Applied in changeset commit:b00e94e904d80fd058801a5574faa5731963798f.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Testing
Done Ratio changed 0 90
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1467#note-10 Originally created by Fahar Abbas at 2016-08-05 04:44:46 UTC.

This is resolved.

Tested Platform: Windows 07 32(Python 2.7) Ubuntu 14.04 Linux 64(Python 3.4).

Commit ID:

commit a43f053a10327fae02c259ce0f791f8c57e9ec09

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1467#note-11 Originally created by Fahar Abbas at 2018-01-09 04:39:26 UTC.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.