pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.53k stars 656 forks source link

PLEASE put the tab close icon IN the tab header (RM #6626) #4456

Closed dpage closed 2 years ago

dpage commented 3 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/6626 Originally created by Dave Caughey at 2021-07-19 14:48:25 UTC.

pgAdmin's tabs are so different from any other tabbed window in any other browser!

E.g., almost every other modern application has the "X" icon in the tab header. Check out how Chrome/Firefox/Edge all handle them, or Eclipse/Netbeans, etc. They ALL have the "X" in the tab header, not to the right hand side of the application. This means to close a bunch of tabs, you have to select one, move your mouse all the way to the right, click "X", then move your mouse to select another tab, then move your mouse back to the far right to click "X", etc. Even worse, pgAdmin layers the "X" on top of the browser text (see attached screenshot).

Note that almost all applications (i.e., check any browser) show the "X" all the time, but Eclipse only shows the "X" when you hover over the tab. I think Eclipse's approach is slightly better, but it's a very minor improvement. Either approach would be vastly better than having a single "X" icon at the far right side of the application.

Also note that all applications show the active tab header as white, with all the other tabs in using a non-white background colour (e.g., light grey, or the colour of the title bar, etc.). You'll even note that Redmine takes this approach for its tab bar. Instead, pgAdmin uses a subtle blue coloured bar at the bottom of the tab header.

Take a cue from apps that are used by billions of people (e.g., browsers)... those have undergone enormous usability testing (there's a reason they don't highlight the active tab by a subtle coloured bar!), and are now how people invariably expect to see tabbed windows. Perhaps pgAdmin is modelled after some alternative UI's (Linux?), but again there's a reason those platforms aren't as widely adopted (clunky UI is one).

If the reason for using the coloured bar is that creating rounded corner tab headers that blend in with the actual window (see, Chrome/Edge/Eclipse for example) would be too difficult, then you can take the same (easier) route that Firefox did, which is to just put border around the active tab header (with a white background), and not even attempt to make the tab header look like an actual tab on an actual (paper) file folder. Either would be fine.

dpage commented 3 years ago

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/5987 Originally created by Dave Caughey at 2021-07-19 14:29:40 UTC.

screenshot.png

Filename: screenshot.png

dpage commented 3 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6626#note-2 Originally created by Aditya Toshniwal at 2021-07-20 04:52:21 UTC.

Duplicates #4538.

Redmine ticket header update:

Name Old Value New Value
Status changed New Rejected
dpage commented 3 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6626#note-3 Originally created by Aditya Toshniwal at 2021-07-20 04:52:33 UTC.

Redmine ticket header update:

Name Old Value New Value
Relationship (duplicates) changed RM #4538
dpage commented 2 years ago

Issue closed on Redmine.