search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.43k stars 638 forks source link

Exception display if select Font size less then 1 for SQL text (RM #1567) #507

Closed dpage closed 2 years ago

dpage commented 8 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/1567 Originally created by Fahar Abbas at 2016-08-18 12:22:16 UTC.

Tested Platform: Windows 2012 server 64(Python 2.7.11) MAC 10.9(Python 3.5)

Commit ID:

commit 48a50ce20be3e6ebdacd0a9632b76ca6aba7cc1d

(venv) C:\Projects\pgadmin4\web>python pgAdmin4.py Starting pgAdmin 4. Please navigate to http://localhost:5050 in your browser. 2016-08-18 18:15:06,456: ERROR pgadmin: Exception on /preferences/prefer ences/60 [PUT] Traceback (most recent call last): File "C:\Projects\venv\lib\site-packages\flask\app.py", line 1988, in wsgi_app

response = self.full_dispatch_request()

File "C:\Projects\venv\lib\site-packages\flask\app.py", line 1641, in full_dis patch_request rv = self.handle_user_exception(e) File "C:\Projects\venv\lib\site-packages\flask\app.py", line 1544, in handle_u ser_exception reraise(exc_type, exc_value, tb) File "C:\Projects\venv\lib\site-packages\flask\app.py", line 1639, in full_dis patch_request rv = self.dispatch_request() File "C:\Projects\venv\lib\site-packages\flask\app.py", line 1625, in dispatch _request return self.view_functionsrule.endpoint File "C:\Projects\venv\lib\site-packages\flask_login.py", line 792, in decorat ed_view return func(*args, **kwargs) File "C:\Projects\pgadmin4\web\pgadmin\preferences__init__.py", line 154, in save res, msg = Preferences.save(data['mid'], data['cid'], data['id'], data['valu e']) File "C:\Projects\pgadmin4\web\pgadmin\utils\preferences.py", line 535, in sav e current_app.logger.exeception(e) AttributeError: 'DebugLogger' object has no attribute 'exeception'

How I tested:

  1. Launch pgAdmin4
  2. Go into preferences
  3. select font size 0.9 instead of 1
  4. Execption displayed in terminal
  5. and If user check the value this is still display 1 instead of change value
dpage commented 8 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/1531 Originally created by Fahar Abbas at 2016-08-18 12:21:44 UTC.

https://pgadmin-archive.postgresql.org/redmine/1567/1531-Screen_Shot_2016-08-18_at_5.15.02_pm.png

dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1567#note-2 Originally created by Akshay Joshi at 2016-08-19 06:53:01 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Akshay Joshi
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1567#note-3 Originally created by Akshay Joshi at 2016-08-19 07:45:51 UTC.

Patch Sent: https://www.postgresql.org/message-id/CANxoLDc=LoH2rL8DsoT1NMRefByaox1YGVHhaA+7UqEcedhiDw@mail.gmail.com

dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1567#note-4 Originally created by Akshay Joshi at 2016-08-19 10:00:10 UTC.

Applied in changeset commit:86858b18f65d9c861196180b8fec6a7b704e7b70.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1567#note-5 Originally created by Fahar Abbas at 2016-08-22 05:15:21 UTC.

I can not test this RM due to regression issue https://redmine.postgresql.org/issues/1572

dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1567#note-6 Originally created by Akshay Joshi at 2016-08-22 05:28:33 UTC.

RM #1572 is not an issue, as discuss with Dave we have moved Font Size settings to "SQL Editor -> Options"

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Akshay Joshi Fahar Abbas
dpage commented 8 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1567#note-7 Originally created by Fahar Abbas at 2016-08-22 05:41:29 UTC.

This issue is resolved in latest commit ID:

commit 5690dfda16ed114107a511db2870a0596ad59a5d

Tested Platform: Windows 2012 server 64(Python 2.7.11) Ubuntu 14.04 Linux 64(Python 3.4.3)

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1567#note-8 Originally created by Fahar Abbas at 2018-01-09 04:41:13 UTC.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.