search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.52k stars 654 forks source link

Allow Editing of Generated SQL from View/Edit Data Menu (RM #7465) #5139

Closed dpage closed 2 years ago

dpage commented 2 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/7465 Originally created by Anthony DeBarros at 2022-06-10 15:05:07 UTC.

When a user selects any of the options under the View/Edit Data menu in the object browser, pgAdmin provides the generated SQL query and the result of the query (e.g., first 100 rows).

It would be helpful to then be able to edit the generated SQL to re-run the query in modified form and also to save a fresh query file.

dpage commented 2 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7465#note-1 Originally created by Nikhil Mohite at 2022-06-24 11:44:56 UTC.

Redmine ticket header update:

Name Old Value New Value
Relationship (duplicates) changed RM #5436
dpage commented 2 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7465#note-2 Originally created by Nikhil Mohite at 2022-06-24 11:45:17 UTC.

Duplicate of #5436

Redmine ticket header update:

Name Old Value New Value
Status changed New Rejected
dpage commented 2 years ago

Issue closed on Redmine.

mark-orion commented 1 year ago

Why is this marked as closed and completed ? I am using the latest version 6.19 and I am still not able to edit the queries shown/generated on the View/Edit Data page. I might have missed something, but otherwise this is highly inconvenient.

dpage commented 1 year ago

Because the import script used to migrate from Redmine was only able to close an issue in that way. The issue was closed originally on Redline because it was a duplicate, as noted above.

mark-orion commented 1 year ago

Can it then be re-opened because I do find having this functionality is essential for an easy workflow.

dpage commented 1 year ago

No, because it's a duplicate ticket. The original one (https://github.com/pgadmin-org/pgadmin4/issues/3499) is also closed though, because there are other ways of getting an editable script, and general consensus amongst users was that that method is preferred and the View/Edit Data method should stay as-is.

mark-orion commented 1 year ago

understand. Thanks for the quick reponse.