pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.43k stars 638 forks source link

Properly handle databases with datallowconn == false (RM #1801) #679

Closed dpage closed 2 years ago

dpage commented 7 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/1801 Originally created by Dave Page at 2016-10-03 13:35:37 UTC.

At present selecting a database with datallowconn == false will throw an error if the SQL tab is visible, or if the properties tab is selected, none of the data is updated.

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-1 Originally created by Dave Page at 2016-10-24 09:10:40 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 1.1 1.2
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-2 Originally created by Khushboo Vashi at 2016-11-18 11:26:22 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Khushboo Vashi
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-3 Originally created by Khushboo Vashi at 2016-11-18 13:04:08 UTC.

Patch Submitted.

https://www.postgresql.org/message-id/CAFOhELf1vE0xu5oxv8Mq2cHioDUoF5a3BgSqgJ96n9O5ASB8GQ@mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-4 Originally created by Dave Page at 2016-11-18 14:15:53 UTC.

All good, but this is just infrastructure for what's really required; i.e. disabling menu options to do things like backups, run the query tool etc. (anything that needs a connection). Can you resolve that please?

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-5 Originally created by Khushboo Vashi at 2016-11-24 08:59:19 UTC.

The updated patch submitted.

https://www.postgresql.org/message-id/CAFOhELcsgAEFpi6CPqVRcqUAkWUpYi5AP%3DQCNUm2Ndp4kBV%2Bbg%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-6 Originally created by Khushboo Vashi at 2016-12-02 11:07:06 UTC.

The patch submitted.

https://www.postgresql.org/message-id/CAFOhELd7-gVPuiXGH_b_cDLVdEP8pQmFVCO55DB5jXt32UjWng%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-7 Originally created by Khushboo Vashi at 2016-12-09 05:34:07 UTC.

The updated patch submitted.

https://www.postgresql.org/message-id/CAFOhELftFnNWYTOoTSXOZEjkNw1CMpmBZFnW%3Ds__5sKGQUr-DQ%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-8 Originally created by Khushboo Vashi at 2016-12-09 11:59:18 UTC.

Applied in changeset commit:81841cdb3c23141b08de4c5ca2d8d21847470035.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-9 Originally created by Fahar Abbas at 2016-12-16 09:47:26 UTC.

This RM is resolved and now user can not see option, except, create drop, properties and refresh if allow_connections=false with straight forward scenario. Verification is still in progress for other scenarios.

Tested Platform: MAC 10.9(Python 3.5) Windows 2012 server 64(Python 2.7.11)

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-10 Originally created by Fahar Abbas at 2016-12-16 10:05:42 UTC.

commit ID:

commit 686237413cc64ee93bdf5844036150beb0fbe43d

dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1801#note-11 Originally created by Fahar Abbas at 2018-01-09 04:47:10 UTC.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.