search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.53k stars 656 forks source link

Query Tool Does Not Recognize When File Changes Have Been Saved (RM #1807) #681

Closed dpage closed 2 years ago

dpage commented 8 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/1807 Originally created by Anthony DeBarros at 2016-10-04 01:56:14 UTC.

Steps to reproduce using pgAdmin 4 v1.0 on MacOS Sierra:

  1. Launch pgAdmin and connect to local database.
  2. Open Query Tool.
  3. In the blank window, enter some code for a query.
  4. The Floppy DIsk (Save) icon highlights.
  5. Click the Floppy Disk icon to save the query file. Choose a folder location such as Desktop and fill in a file name.
  6. Click Save in the dialog box to save the file. pgAdmin reports "File Saved Successfully."
  7. Note that the Floppy Disk icon is no longer highlighted because there are no unsaved changes.
  8. Click the "X" at top right of the Query Tool to "Close the currently active panel tab."
  9. pgAdmin reports (incorrectly) that the "query has been modified but not saved. Do you wish to save changes?"
  10. You must click Yes to proceed, even though the additional save action was unneeded.
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1807#note-1 Originally created by Jeff Dafoe at 2016-12-12 17:40:14 UTC.

There's an easy way to reproduce this error. Open a file in the query tool. Then press the close (X) icon. You'll be prompted with "The query has been modified, but not saved. Are you sure you wish to discard the changes?".

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1807#note-2 Originally created by Dave Page at 2016-12-13 09:08:58 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 1.2
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1807#note-3 Originally created by Akshay Joshi at 2016-12-16 06:48:02 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Akshay Joshi
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1807#note-4 Originally created by Akshay Joshi at 2016-12-16 08:51:31 UTC.

Patch sent to pgadmin-hackers https://www.postgresql.org/message-id/CANxoLDeuyz5d1+kKmpXiSdDMmtRGnKV+6dNmvtHeBTPjw6XV3w@mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1807#note-5 Originally created by Akshay Joshi at 2017-01-08 09:58:07 UTC.

Applied in changeset commit:ae809c4506a4c72b914ea61dd1d6202644d708aa.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1807#note-6 Originally created by Fahar Abbas at 2017-01-24 08:31:27 UTC.

This issue is also resolved with Desktop application as well as web based application.

Tested Platform: MAC 10.10 MAC 10.9(Python 3.5) Windows 2012 server 64 bit.

Commit ID:

commit b4d4cffc608c44a5574fbe433ab9fa1f9fbd58ed

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1807#note-7 Originally created by Fahar Abbas at 2018-01-09 04:47:10 UTC.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.