pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.43k stars 637 forks source link

cannot create gist index due to enforced ASC, DESC options in generated SQL (RM #1840) #708

Closed dpage closed 2 years ago

dpage commented 7 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/1840 Originally created by Donovan Cameron at 2016-10-06 18:05:01 UTC.

I'm trying to create a gist based index on a PostGIS geometry column and can't because the SQL tab in the Create - Index window adds some stuff to the SQL that makes it invalid.

It generates ERROR: access method "gist" does not support ASC/DESC options

I can't manually change the SQL (<- this would be a great feature!) in that SQL tab:

// Incorrect @CREATE INDEX table_geom_geom_idx ON schema.table USING gist (geom ASC NULLS LAST) TABLESPACE pg_default;@

// Correct @CREATE INDEX table_geom_geom_idx ON schema.table USING gist (geom) TABLESPACE pg_default;@

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-1 Originally created by Dave Page at 2016-10-07 13:06:34 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 1.1
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-2 Originally created by Dave Page at 2016-10-19 09:47:41 UTC.

Redmine ticket header update:

Name Old Value New Value
Priority changed Normal High
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-3 Originally created by Surinder Kumar at 2016-10-20 05:46:51 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Surinder Kumar
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-4 Originally created by Surinder Kumar at 2016-10-20 07:01:26 UTC.

patch is sent to pgadmin-hackers.

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-5 Originally created by Surinder Kumar at 2016-10-21 11:08:45 UTC.

Applied in changeset commit:06039320b941d3d98f1ab044320ba177e47d0f9c.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 7 years ago

Attachment migrated from Redmine: https://redmine.postgresql.org/attachments/download/1836 Originally created by priyanka shendge at 2016-10-21 13:35:58 UTC.

https://pgadmin-archive.postgresql.org/redmine/1840/1836-Screen_Shot_2016-10-21_at_7.05.29_pm.png

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-7 Originally created by priyanka shendge at 2016-10-21 13:36:04 UTC.

applicable for exclusion constraint as well... throwing same error for exclusion constraint

Redmine ticket header update:

Name Old Value New Value
Attachment added Screen Shot 2016-10-21 at 7.05.29 pm.png
Status changed In Testing New
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-8 Originally created by Surinder Kumar at 2016-10-21 13:50:45 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-9 Originally created by Surinder Kumar at 2016-10-21 15:17:21 UTC.

patch is sent https://www.postgresql.org/message-id/CA%2BOCxowGDMCf_YJauW%3Du24X_7X4XMnT5tkca4qMRZCpH8z2mDA%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-10 Originally created by Dave Page at 2016-10-27 10:35:13 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 1.1 1.2
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-11 Originally created by Surinder Kumar at 2016-11-24 12:14:55 UTC.

updated patch: https://www.postgresql.org/message-id/CAM5-9D97YhGDXQZfOg%2BFBf0nDedQvydWH%2BmAmr2iRi0rOL9PSA%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-12 Originally created by Surinder Kumar at 2017-01-13 06:53:17 UTC.

Please find updated patch following changes: 1) Keep field 'opclass' combo box enabled. 2) Keep ASC/DESC and NULLs FIRST/LAST options disable for access methods other than 'btree'. 3) Add validation for name field.

patch sent at pgadmin-hackers https://www.postgresql.org/message-id/CAM5-9D-%2BuETwn4_LqHOGAwk46Wg6U-udSV_WrAy%3DFHnKwffhFA%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-13 Originally created by Surinder Kumar at 2017-01-20 07:31:33 UTC.

updated patch is sent to pgadmin-hackers. https://www.postgresql.org/message-id/CAM5-9D91tXWjTt0AEzOyUbukmSMw9QA9+xoav7caddY_ig0C7w@mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-14 Originally created by Surinder Kumar at 2017-01-25 13:21:43 UTC.

Applied in changeset commit:e01cf748eafcb53c4040500c099f2e06fabf8ea8.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-15 Originally created by Fahar Abbas at 2017-01-26 10:35:02 UTC.

This RM is resolved with latest commit ID for gist indexes

Tested Platform: Windows 2012 server 64 (Python 2.7.11) MAC 10.9(Python 3.5)

Commit ID:

commit e01cf748eafcb53c4040500c099f2e06fabf8ea8

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/1840#note-16 Originally created by Fahar Abbas at 2018-01-09 04:47:10 UTC.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.