pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.55k stars 659 forks source link

Limitation in personalization of oauth icon #7641

Open xav-hydra opened 4 months ago

xav-hydra commented 4 months ago

Describe the bug

I am using Keycloak to authenticate to pgAdmin (oauth), and since there is no Font Awesome Keycloak icon, I would like to be able to use any type of icon, not just the brand ones.

As we can see in the pgadmin source

<Icon className={'fab '+oauth.OAUTH2_ICON} style={{ fontSize: '1.5em', marginRight: '8px' }} />{gettext('Login with %s', oauth.OAUTH2_DISPLAY_NAME)}
                  /\
                  ||

The fab icon specification is mandatory.

To Reproduce

Put any other icon that is not a fab icon in the OAUTH2_ICON ( doc ) variable.

Expected behavior

Any icon should appear.

Error message

none

Screenshots

example with right-to-bracket icon same result with or without any other type of Font Awesome icon type in OAUTH2_ICON (here fas)

image

Additional context

none

florian4f6c6 commented 3 months ago

Hello, can i work in it?

khushboovashi commented 3 months ago

Hello, can i work in it?

Yes, you can.

xav-hydra commented 3 months ago

Hello, can't we just remove the fab prefix and update the doc accordingly ? Should be an quick "fix".

florian4f6c6 commented 3 months ago

Hello, can't we just remove the fab prefix and update the doc accordingly ? Should be an quick "fix".

but then we also need an Option to import other Stylesheet